Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default k adapt to data length #90

Open
RibeiroAndre opened this issue Mar 3, 2022 · 0 comments
Open

Default k adapt to data length #90

RibeiroAndre opened this issue Mar 3, 2022 · 0 comments

Comments

@RibeiroAndre
Copy link

Hello,
Currently this:

a=Spline1D([1,2,3],[2,4,8])

fails because k is 3 by default.
I propose that if the data length is 2, k=1, if it's 3, k=2, otherwise, k=3.
So the code change would likely be:

function Spline1D(x::AbstractVector, y::AbstractVector,
                  ...,
                  k::Int=min(length(x)-1,3), ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant