Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent blog posts shows "nothing" for the blog post content #2144

Closed
ViralBShah opened this issue Sep 13, 2024 · 6 comments · Fixed by #2157
Closed

Recent blog posts shows "nothing" for the blog post content #2144

ViralBShah opened this issue Sep 13, 2024 · 6 comments · Fixed by #2157
Labels

Comments

@ViralBShah
Copy link
Member

Screenshot 2024-09-13 at 10 37 30 AM
@cormullion
Copy link
Contributor

cormullion commented Oct 5, 2024

I think this error was introduced in the update of July 23rd:

9abba82#diff-77f6106b330f94b72767e939c4331f770846d06af4f97415d941b404087155daR65

where this code was added.

     # Franklin.pagevar appears to be an internal function that has a guard against
      # recursive overflow so we need to reset the counter to 0, otherwise we cannot read
      # pagevars for all pages.
      Franklin.PAGEVAR_DEPTH[] = 0
      title = pagevar(surl, :title; default="Untitled")

However my Franklin's a bit too rusty/basic for fixing this - perhaps we could get Thibaut to have a look...?

Also, there's an error in the footer:

Image

which looks to have been added here

(by @IanButterworth I think). I don't know where this mtime is defined though.

@IanButterworth
Copy link
Member

I'll look into this.

@cormullion
Copy link
Contributor

However my Franklin's a bit too rusty/basic for fixing this - perhaps we could get Thibaut to have a look...?

Perhaps this is where we’d insert @delay as mentioned here:

tlienart/Franklin.jl#924 (comment)

@cormullion
Copy link
Contributor

@IanButterworth Thanks! (And sorry for finding more work for you 😀)

@cormullion
Copy link
Contributor

Image

@giordano
Copy link
Contributor

giordano commented Oct 7, 2024

That's #2136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants