Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multidimensional generic FFTs, perhaps in a separate package? #86

Closed
mfherbst opened this issue Oct 31, 2019 · 3 comments
Closed

Multidimensional generic FFTs, perhaps in a separate package? #86

mfherbst opened this issue Oct 31, 2019 · 3 comments

Comments

@mfherbst
Copy link
Contributor

I would be interested to see the generic Fourier transforms implemented in this package to be extended to the multi-dimensional case. There's been quite some interest in generic FFTs in the community, see e.g. JuliaMath/AbstractFFTs.jl#34 and JuliaMath/AbstractFFTs.jl#29, so I guess it would not hurt to polish the code some more and fully integrate it with the philosophy of https://github.com/JuliaMath/AbstractFFTs.jl. PR #85 is a first attempt in this direction.

From my point of view, it would be helpful to move the existing fftBigFloat Code into a separate package, say GenericFFT and continue polishing it there. It does not really depend on anything else in here and thus moving it to a different package would make depending on the generic FFT code from the Julia ecosystem easier and more lightweight. I'm happy to make the first steps in this direction if the maintainers of this package agree, but I'm also happy to hear other opinions 😄.

@dlfivefifty
Copy link
Member

I think we definitely support this!

@MikaelSlevinsky
Copy link
Member

Looking at the links you provided, I believe that this package’s FFT’s should ultimately be deprecated in favour of https://github.com/JuliaComputing/FourierTransforms.jl Those look like they are generically written (and create micro-kernels for more prime factors), though it might take a hacking session to make it work for one’s needs.

@mfherbst
Copy link
Contributor Author

mfherbst commented Nov 4, 2019

Thanks for that pointer! I fully agree and I must have completely overlooked this project. Definitely what I had in mind and what I was looking for! I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants