Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Transitioned repos have unnecessary words added to their cspell.json #2062

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 28, 2025 · 2 comments · Fixed by #2067
Closed
3 tasks done

🐛 Bug: Transitioned repos have unnecessary words added to their cspell.json #2062

JoshuaKGoldberg opened this issue Mar 28, 2025 · 2 comments · Fixed by #2067
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Transition Mode D...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running npx create-typescript-app on a repo that already has cspell.json and pnpm lint:spelling working nicely shouldn't add new, unnecessary words entries.

Actual

https://github.com/JoshuaKGoldberg/eslint-fix-utils/pull/79/files#diff-77519f787fe7e051a14c588f101d61e4d8f0d3b01bf8e16cb65d3838243d4e68R12-R17 ☹

	"words": [
		"apexskier",
		"automerge",
		"joshuakgoldberg",
		"markdownlintignore",
		"tseslint"
	]

Additional Info

🎁
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Mar 28, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 28, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 28, 2025
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🐛 Bug: Generated repos have unnecessary words added to their cspell.json 🐛 Bug: Transitioned repos have unnecessary words added to their cspell.json Mar 28, 2025
@JoshuaKGoldberg
Copy link
Owner Author

As of #2066, it's now just:

"words": ["apexskier", "joshuakgoldberg", "markdownlintignore"]

Those three words aren't necessary. pnpm lint:spelling passes without them in JoshuaKGoldberg/eslint-fix-utils#79.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 28, 2025
Merged
3 tasks
@github-actions GitHub Actions
Copy link

🎉 This is included in version v2.18.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Transition Mode Dogfooding
Development

Successfully merging a pull request may close this issue.

fix: remove remaining manual cspell word additions JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg