Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bug: Release flow doesn't understand ! in title type #1983

Open
3 tasks done
JoshuaKGoldberg opened this issue Mar 17, 2025 · 0 comments
Open
3 tasks done

🐛 Bug: Release flow doesn't understand ! in title type #1983

JoshuaKGoldberg opened this issue Mar 17, 2025 · 0 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Coming over from JoshuaKGoldberg/eslint-plugin-package-json#963: if a PR title has a ! after its type -e.g. feat!:- it should still be treated as that type - e.g. feat:. The commit should have triggered a version 0.27.0.

Actual

Instead:

Additional Info

Related: #1671. This isn't specific to major versions as the package in question is still 0.x. But is in the same area of how to deal with !s / breaking changes.

🎁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

1 participant