refactor: use queueMicrotask to schedule micro tasks instead of various helpers (angular#50485)

`queueMicrotask` is an API which is supported by all browser and Node.js versions.

PR Close angular#50485

Author: alan-agius4

packages/animations/src/players/animation_group_player.ts

@@ -6,8 +6,6 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {scheduleMicroTask} from '../util';
-
 import {AnimationPlayer} from './animation_player';
 
 /**
@@ -38,7 +36,7 @@ export class AnimationGroupPlayer implements AnimationPlayer {
     const total = this.players.length;
 
     if (total == 0) {
-      scheduleMicroTask(() => this._onFinish());
+      queueMicrotask(() => this._onFinish());
     } else {
       this.players.forEach(player => {
         player.onDone(() => {

packages/animations/src/players/animation_player.ts

@@ -5,7 +5,6 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-import {scheduleMicroTask} from '../util';
 
 /**
  * Provides programmatic control of a reusable animation sequence,
@@ -166,7 +165,7 @@ export class NoopAnimationPlayer implements AnimationPlayer {
 
   /** @internal */
   triggerMicrotask() {
-    scheduleMicroTask(() => this._onFinish());
+    queueMicrotask(() => this._onFinish());
   }
 
   private _onStart() {

packages/animations/src/util.ts

@@ -6,9 +6,9 @@
  * found in the LICENSE file at https://angular.io/license
  */
 import {fakeAsync} from '@angular/core/testing';
+
 import {flushMicrotasks} from '../../core/testing/src/fake_async';
 import {NoopAnimationPlayer} from '../src/players/animation_player';
-import {scheduleMicroTask} from '../src/util';
 
 {
   describe('NoopAnimationPlayer', function() {
@@ -70,7 +70,7 @@ import {scheduleMicroTask} from '../src/util';
 
          const player = new NoopAnimationPlayer();
          player.onStart(() => {
-           scheduleMicroTask(() => log.push('started'));
+           queueMicrotask(() => log.push('started'));
          });
          player.onDone(() => log.push('done'));
          expect(log).toEqual([]);

packages/animations/test/animation_player_spec.ts

@@ -5,16 +5,15 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-import {scheduleMicroTask} from '../src/util';
 
 {
   describe('util', () => {
     it('should schedule a microtask and not call an async timeout', (done) => {
       let count = 0;
-      scheduleMicroTask(() => count++);
+      queueMicrotask(() => count++);
 
       expect(count).toEqual(0);
-      Promise.resolve().then(() => {
+      queueMicrotask(() => {
         expect(count).toEqual(1);
         done();
       });

packages/animations/test/util_spec.ts

@@ -47,7 +47,7 @@ const SAMPLE_REQ = new HttpRequest<never>('JSONP', '/test');
     // Issue #39496
     it('handles a request with callback call wrapped in promise', done => {
       backend.handle(SAMPLE_REQ).subscribe({complete: done});
-      Promise.resolve().then(() => {
+      queueMicrotask(() => {
         runOnlyCallback(home, {data: 'This is a test'});
       });
       document.mockLoad();

packages/common/http/test/jsonp_spec.ts

@@ -7,7 +7,6 @@
  */
 
 import {Inject, Injectable, InjectionToken} from '../di';
-import {scheduleMicroTask} from '../util/microtask';
 import {NgZone} from '../zone/ng_zone';
 
 /**
@@ -127,7 +126,7 @@ export class Testability implements PublicTestability {
       this._ngZone.onStable.subscribe({
         next: () => {
           NgZone.assertNotInAngularZone();
-          scheduleMicroTask(() => {
+          queueMicrotask(() => {
             this._isZoneStable = true;
             this._runCallbacksIfReady();
           });
@@ -169,7 +168,7 @@ export class Testability implements PublicTestability {
   private _runCallbacksIfReady(): void {
     if (this.isStable()) {
       // Schedules the call backs in a new frame so that it is always async.
-      scheduleMicroTask(() => {
+      queueMicrotask(() => {
         while (this._callbacks.length !== 0) {
           let cb = this._callbacks.pop()!;
           clearTimeout(cb.timeoutId);

packages/core/src/testability/testability.ts

@@ -13,12 +13,15 @@ import {inject, InjectionToken} from '../di';
 import {RuntimeError, RuntimeErrorCode} from '../errors';
 import {EventEmitter} from '../event_emitter';
 import {global} from '../util/global';
-import {scheduleMicroTask} from '../util/microtask';
 import {noop} from '../util/noop';
 import {getNativeRequestAnimationFrame} from '../util/raf';
 
 import {AsyncStackTaggingZoneSpec} from './async-stack-tagging';
 
+// The below is needed as otherwise a number of targets fail in G3 due to:
+// ERROR - [JSC_UNDEFINED_VARIABLE] variable Zone is undeclared
+declare const Zone: any;
+
 /**
  * An injectable service for executing work inside or outside of the Angular zone.
  *
@@ -547,7 +550,7 @@ export function isStableFactory() {
 
         // Check whether there are no pending macro/micro tasks in the next tick
         // to allow for NgZone to update the state.
-        scheduleMicroTask(() => {
+        queueMicrotask(() => {
           if (!_stable && !zone.hasPendingMacrotasks && !zone.hasPendingMicrotasks) {
             _stable = true;
             observer.next(true);

packages/core/src/util/microtask.ts

@@ -1289,9 +1289,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "provideZoneChangeDetection"
   },
@@ -1358,9 +1355,6 @@
   {
     "name": "scheduleArray"
   },
-  {
-    "name": "scheduleMicroTask"
-  },
   {
     "name": "searchTokensOnInjector"
   },

packages/core/src/zone/ng_zone.ts

@@ -1364,9 +1364,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "refCount"
   },
@@ -1430,12 +1427,6 @@
   {
     "name": "scheduleArray"
   },
-  {
-    "name": "scheduleMicroTask"
-  },
-  {
-    "name": "scheduleMicroTask2"
-  },
   {
     "name": "searchTokensOnInjector"
   },

packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json

@@ -1085,9 +1085,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "refCount"
   },
@@ -1133,9 +1130,6 @@
   {
     "name": "scheduleArray"
   },
-  {
-    "name": "scheduleMicroTask"
-  },
   {
     "name": "searchTokensOnInjector"
   },

packages/core/test/bundling/animations/bundle.golden_symbols.json

@@ -1499,9 +1499,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "providerToFactory"
   },
@@ -1571,9 +1568,6 @@
   {
     "name": "scheduleArray"
   },
-  {
-    "name": "scheduleMicroTask"
-  },
   {
     "name": "searchTokensOnInjector"
   },

packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json

@@ -1463,9 +1463,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "providerToFactory"
   },
@@ -1547,9 +1544,6 @@
   {
     "name": "scheduleArray"
   },
-  {
-    "name": "scheduleMicroTask"
-  },
   {
     "name": "searchTokensOnInjector"
   },

packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json

@@ -857,9 +857,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "refCount"
   },

packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json

@@ -1151,9 +1151,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "provideZoneChangeDetection"
   },

packages/core/test/bundling/hello_world/bundle.golden_symbols.json

@@ -1763,9 +1763,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "provideZoneChangeDetection"
   },

packages/core/test/bundling/hydration/bundle.golden_symbols.json

@@ -950,9 +950,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "provideZoneChangeDetection"
   },

packages/core/test/bundling/router/bundle.golden_symbols.json

@@ -1289,9 +1289,6 @@
   {
     "name": "profiler"
   },
-  {
-    "name": "promise"
-  },
   {
     "name": "refCount"
   },
@@ -1346,9 +1343,6 @@
   {
     "name": "scheduleArray"
   },
-  {
-    "name": "scheduleMicroTask"
-  },
   {
     "name": "searchTokensOnInjector"
   },

packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json

@@ -10,17 +10,16 @@ import {EventEmitter} from '@angular/core';
 import {Injectable} from '@angular/core/src/di';
 import {GetTestability, PendingMacrotask, Testability, TestabilityRegistry} from '@angular/core/src/testability/testability';
 import {NgZone} from '@angular/core/src/zone/ng_zone';
-import {fakeAsync, flush, tick, waitForAsync} from '@angular/core/testing';
+import {fakeAsync, tick, waitForAsync} from '@angular/core/testing';
 
 import {setTestabilityGetter} from '../../src/testability/testability';
-import {scheduleMicroTask} from '../../src/util/microtask';
 
-// Schedules a microtasks (using a resolved promise .then())
+// Schedules a microtasks (using queueMicrotask)
 function microTask(fn: Function): void {
-  scheduleMicroTask(() => {
-    // We do double dispatch so that we  can wait for scheduleMicrotask in the Testability when
+  queueMicrotask(() => {
+    // We do double dispatch so that we can wait for queueMicrotask in the Testability when
     // NgZone becomes stable.
-    scheduleMicroTask(fn);
+    queueMicrotask(() => fn());
   });
 }