Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen filtering settings applies to Software renderer but the setting is hidden #250

Open
5 of 11 tasks
Linx-ESP opened this issue Jan 15, 2025 · 2 comments
Open
5 of 11 tasks
Labels
bug Something isn't working

Comments

@Linx-ESP
Copy link

Linx-ESP commented Jan 15, 2025

What version of melonDS DS are you using?

1.1.8

Does the problem happen in standalone melonDS?

I don't know.

What happened?

From Core Options - Video - Screen filtering setting.
This setting will also affect software rendering but it will not show if you have Render Mode: software.
Any time you want to change it you have to go Render Mode: OpenGL, change filtering, restart in OpenGL, change to Render Mode: Software and restart.

I'm using integer scaling on Retroarch and it has an option for bilinear filtering on the scaling settings. It doesn't do anything in this case.

What should've happened instead?

Either the "Core Options - Video - Screen filtering" setting is shown for Software Render Mode or its function is disabled in favor of Retroarch Scaling setting.

Which platforms do you see the problem on?

  • Windows
  • macOS
  • Linux
  • Android
  • iOS
  • tvOS
  • Other (specify below)

Which versions of the OS?

Windows 11

Which libretro frontend are you using?

RetroArch 1.20.0 Steam

Terms

  • I agree to follow the code of conduct.
  • I understand that melonDS DS is not developed or maintained by the authors of melonDS.
  • I understand that this form is for reporting bugs, not for requesting help.
  • I understand that the author develops this core in his spare time, and that he is under no obligation to respond to this bug report.
@Linx-ESP Linx-ESP added the bug Something isn't working label Jan 15, 2025
@JesseTG
Copy link
Owner

JesseTG commented Jan 27, 2025

Thank you for reporting this (and for your patience). Are you looking to have the whole screen filtered? Or just the hybrid one? I'd like to be sure that this option is well-advised to begin with (since I only added it due to its presence in the legacy core).

JesseTG added a commit that referenced this issue Jan 28, 2025
@Linx-ESP
Copy link
Author

In my case I didn't want any filtering at all. If I wanted I would want all screens, but retroarch or shaders already manage it so I don't know of a use case in the core.
Either way, the toggle should appear in Software rendering, not just OpenGL as it affects both.
Can test a commit build if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants