Skip to content

Commit 9db4b3f

Browse files
committed
Track exit codes to avoid WCT failures blocking WTR.
1 parent da7954e commit 9db4b3f

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414
"ignore-sync": "ignore-sync .",
1515
"lint": "eslint \"**/*.{html,js,ts}\"",
1616
"nuke": "rm -rf package-lock.json node_modules && npm install && lerna exec \"rm -f package-lock.json\" && lerna clean --yes && lerna bootstrap && lerna exec --stream -- \"test -f package-lock.json || npm install --package-lock-only\"",
17-
"test": "wct && lerna run test --concurrency 1 --stream --no-bail",
17+
"test": "EXIT_CODE=0; wct || EXIT_CODE=1; lerna run test --concurrency 1 --stream --no-bail || EXIT_CODE=1; exit $EXIT_CODE",
1818
"test-pack": "lerna exec \"npm pack\"",
19-
"test-sauce": "wct -s 'windows 10/microsoftedge@17' -s 'windows 10/microsoftedge@15' -s 'windows 8.1/internet explorer@11' -s 'macos 10.13/safari@12' -s 'macos 10.13/safari@11' -s 'os x 10.11/safari@10' -s 'os x 10.11/safari@9' -s 'Linux/chrome@41' && npx lerna run test-sauce --concurrency 1 --stream --no-bail"
19+
"test-sauce": "EXIT_CODE=0; wct -s 'windows 10/microsoftedge@17' -s 'windows 10/microsoftedge@15' -s 'windows 8.1/internet explorer@11' -s 'macos 10.13/safari@12' -s 'macos 10.13/safari@11' -s 'os x 10.11/safari@10' -s 'os x 10.11/safari@9' -s 'Linux/chrome@41' || EXIT_CODE=1; npx lerna run test-sauce --concurrency 1 --stream --no-bail || EXIT_CODE=1; exit $EXIT_CODE"
2020
},
2121
"devDependencies": {
2222
"@gulp-sourcemaps/sources-content": "^1.0.0",

packages/tests/shadydom/event-path.html

-4
Original file line numberDiff line numberDiff line change
@@ -1195,8 +1195,6 @@
11951195
});
11961196

11971197
test('composedPath of events from non-Node subclasses works', function (done) {
1198-
this.skip();
1199-
12001198
const xhr = new XMLHttpRequest();
12011199
xhr.open('GET', window.location.href);
12021200
xhr.addEventListener('load', (e) => {
@@ -1632,8 +1630,6 @@
16321630
});
16331631

16341632
test('focus currentTarget is valid when unwrapped in noPatch', function () {
1635-
this.skip();
1636-
16371633
customElements.define(
16381634
'unpatched-focus',
16391635
class extends HTMLElement {

0 commit comments

Comments
 (0)