renamed some configs

Author: SheepishShepherd

BossChecklist.cs

@@ -21,8 +21,8 @@ internal class BossChecklist : Mod {
 
 		public static Dictionary<int, int> itemToMusicReference;
 
-		internal static ClientConfiguration ClientConfig;
 		internal static BossLogConfiguration BossLogConfig;
+		internal static FeatureConfiguration FeatureConfig;
 		public static List<PersonalRecords>[] ServerCollectedRecords;
 
 		public BossChecklist() {
@@ -64,7 +64,7 @@ public override void Unload() {
 			bossTracker = null;
 			ToggleBossLog = null;
 			ServerCollectedRecords = null;
-			ClientConfig = null;
+			FeatureConfig = null;
 			BossLogConfig = null;
 		}
 

BossRadarUI.cs

@@ -164,13 +164,13 @@ private bool SetDrawPos() {
 		//Update
 		public override void Update(GameTime gameTime) {
 			base.Update(gameTime);
-			if (!BossChecklist.ClientConfig.BossRadarBool) return;
+			if (!BossChecklist.FeatureConfig.EnableBossRadar) return;
 
 			if (!whitelistFilled || blacklistChanged) {
 				List<int> idList = new List<int>();
 				foreach (EntryInfo entry in BossChecklist.bossTracker.SortedEntries) {
 					if (entry.type == EntryType.Event) continue;
-					if (entry.type == EntryType.MiniBoss && !BossChecklist.ClientConfig.RadarMiniBosses) continue;
+					if (entry.type == EntryType.MiniBoss && !BossChecklist.FeatureConfig.RadarMiniBosses) continue;
 					foreach (int id in entry.npcIDs) {
 						if (!BlackListedID(id) && GetBossHead(id) != TextureAssets.NpcHead[0]) idList.Add(id);
 					}
@@ -187,14 +187,14 @@ public override void Update(GameTime gameTime) {
 		private Asset<Texture2D> GetBossHead(int boss) => NPCID.Sets.BossHeadTextures[boss] != -1 ? TextureAssets.NpcHeadBoss[NPCID.Sets.BossHeadTextures[boss]] : TextureAssets.NpcHead[0];
 
 		private bool BlackListedID(int ID) {
-			return BossChecklist.ClientConfig.RadarBlacklist.Any(npcDef => npcDef.Type == ID);
+			return BossChecklist.FeatureConfig.RadarBlacklist.Any(npcDef => npcDef.Type == ID);
 		}
 
 		//Draw
 		protected override void DrawSelf(SpriteBatch spriteBatch) {
 			base.DrawSelf(spriteBatch);
 
-			if (!BossChecklist.ClientConfig.BossRadarBool) return;
+			if (!BossChecklist.FeatureConfig.EnableBossRadar) return;
 
 			for (int i = 0; i < type.Count; i++) {
 				Vector2 ldrawPos = drawPos[i]; //contains top left corner of draw pos
@@ -221,13 +221,13 @@ protected override void DrawSelf(SpriteBatch spriteBatch) {
 				Rectangle outputRect = new Rectangle((int)ldrawPos.X - (finalWidth / 2), (int)ldrawPos.Y - (finalHeight / 2), finalWidth, finalHeight);
 
 				Color color = Color.LightGray;
-				color *= drawLOS[i] ? BossChecklist.ClientConfig.OpacityFloat : BossChecklist.ClientConfig.OpacityFloat - 0.25f;
+				color *= drawLOS[i] ? BossChecklist.FeatureConfig.RadarOpacity : BossChecklist.FeatureConfig.RadarOpacity - 0.25f;
 				spriteBatch.Draw(tex.Value, outputRect, new Rectangle(0, 0, tempWidth, tempHeight), color);
 
 				//draw Arrow
 				Vector2 stupidOffset = drawRotation[i].ToRotationVector2() * 24f;
 				Vector2 drawPosArrow = ldrawPos + stupidOffset;
-				color = drawLOS[i] ? Color.Green * BossChecklist.ClientConfig.OpacityFloat : Color.Red * BossChecklist.ClientConfig.OpacityFloat;
+				color = drawLOS[i] ? Color.Green * BossChecklist.FeatureConfig.RadarOpacity : Color.Red * BossChecklist.FeatureConfig.RadarOpacity;
 				color.A = 150;
 				spriteBatch.Draw(arrowTexture.Value, drawPosArrow, null, color, drawRotation[i], arrowTexture.Value.Bounds.Size() / 2, 1f, SpriteEffects.None, 0f);
 			}

BossUISystem.cs

@@ -156,7 +156,7 @@ public override void ModifyInterfaceLayers(List<GameInterfaceLayer> layers) {
 						if (Main.netMode != NetmodeID.SinglePlayer)
 							return true;
 
-						if (BossChecklist.bossTracker.FindEntryByNPC(BossChecklist.ClientConfig.DisplayRecordTracking.Type, out int recordIndex) is not EntryInfo entry)
+						if (BossChecklist.bossTracker.FindEntryByNPC(BossChecklist.FeatureConfig.DisplayRecordTracking.Type, out int recordIndex) is not EntryInfo entry)
 							return true;
 
 						PlayerAssist modplayer = Main.LocalPlayer.GetModPlayer<PlayerAssist>();

Configs.cs

@@ -234,9 +234,9 @@ public override bool AcceptClientChanges(ModConfig pendingConfig, int whoAmI, re
 		}
 	}
 
-	public class ClientConfiguration : ModConfig {
+	public class FeatureConfiguration : ModConfig {
 		public override ConfigScope Mode => ConfigScope.ClientSide;
-		public override void OnLoaded() => BossChecklist.ClientConfig = this;
+		public override void OnLoaded() => BossChecklist.FeatureConfig = this;
 
 		private bool TrackingEnabled;
 		private bool NewRecordsEnabled;
@@ -311,45 +311,35 @@ public bool AllowNewRecords {
 		[Header("ItemMapDetection")]
 
 		[DefaultValue(true)]
-		[LabelKey("$Mods.BossChecklist.Configs.ClientConfiguration.TreasureBags.Label")]
-		[TooltipKey("$Mods.BossChecklist.Configs.ClientConfiguration.TreasureBags.Tooltip")]
-		public bool TreasureBagsBool { get; set; }
+		public bool TreasureBagsOnMap { get; set; }
 
 		[DefaultValue(true)]
-		[LabelKey("$Mods.BossChecklist.Configs.ClientConfiguration.Fragments.Label")]
-		[TooltipKey("$Mods.BossChecklist.Configs.ClientConfiguration.Fragments.Tooltip")]
-		public bool FragmentsBool { get; set; }
+		public bool FragmentsOnMap { get; set; }
 
 		[DefaultValue(false)]
-		[LabelKey("$Mods.BossChecklist.Configs.ClientConfiguration.Scales.Label")]
-		[TooltipKey("$Mods.BossChecklist.Configs.ClientConfiguration.Scales.Tooltip")]
-		public bool ScalesBool { get; set; }
+		public bool ScalesOnMap { get; set; }
 
 		[Header("BossRadar")]
 
 		[DefaultValue(true)]
-		[LabelKey("$Mods.BossChecklist.Configs.ClientConfiguration.BossRadar.Label")]
-		[TooltipKey("$Mods.BossChecklist.Configs.ClientConfiguration.BossRadar.Tooltip")]
-		public bool BossRadarBool { get; set; }
+		public bool EnableBossRadar { get; set; }
 
 		[DefaultValue(false)]
 		public bool RadarMiniBosses { get; set; }
 
 		public const float OpacityFloatMin = 0.35f;
 		public const float OpacityFloatMax = 0.85f;
-		[LabelKey("$Mods.BossChecklist.Configs.ClientConfiguration.RadarOpacity.Label")]
-		[TooltipKey("$Mods.BossChecklist.Configs.ClientConfiguration.RadarOpacity.Tooltip")]
 		[Range(OpacityFloatMin, OpacityFloatMax)]
 		[DefaultValue(0.75f)]
-		public float OpacityFloat { get; set; }
+		public float RadarOpacity { get; set; }
 
 		public List<NPCDefinition> RadarBlacklist { get; set; } = new List<NPCDefinition>();
 
 		[OnDeserialized]
 		internal void OnDeserializedMethod(StreamingContext context) {
 			//Range attribute doesn't enforce it onto the value, it's a limit for the UI only, so we have to clamp it here again if user decides to edit it through the json
 			//If this isn't in here, OpacityFloat can get negative for example, which will lead to a crash later
-			OpacityFloat = Utils.Clamp(OpacityFloat, OpacityFloatMin, OpacityFloatMax);
+			RadarOpacity = Utils.Clamp(RadarOpacity, OpacityFloatMin, OpacityFloatMax);
 		}
 
 		public override void OnChanged() {

EntryInfo.cs

@@ -136,12 +136,12 @@ internal bool IsRecordIndexed(out int recordIndex) {
 		/// <returns>A LocalizedText of the despawn message of the passed npc. Returns null if no message can be found.</returns>
 		internal LocalizedText GetDespawnMessage(NPC npc) {
 			// When unique despawn messages are enabled, pass the NPC for the custom message function provided by the entry
-			if (BossChecklist.ClientConfig.DespawnMessageType == "Unique" && customDespawnMessages(npc) is LocalizedText message)
+			if (BossChecklist.FeatureConfig.DespawnMessageType == "Unique" && customDespawnMessages(npc) is LocalizedText message)
 				return message; // this will only return a unique message if the custom message function properly assigns one
 
 			// If the Unique message was empty/null or the player is using Generic despawn messages, try to find an appropriate despawn message to send
 			// Return a generic despawn message if any player is left alive or return a boss victory despawn message if all player's were killed
-			if (BossChecklist.ClientConfig.DespawnMessageType != "Disabled")
+			if (BossChecklist.FeatureConfig.DespawnMessageType != "Disabled")
 				return Language.GetText(Main.player.Any(plr => plr.active && !plr.dead) ? $"{NPCAssist.LangChat}.Despawn.Generic" : $"{NPCAssist.LangChat}.Loss.Generic");
 
 			return null; // The despawn message feature was disabled. Return an empty message.
@@ -152,10 +152,10 @@ internal LocalizedText GetDespawnMessage(NPC npc) {
 		/// These messages will not appear if the related configs are disabled.
 		/// </summary>
 		internal LocalizedText GetLimbMessage(NPC npc) {
-			if (BossChecklist.ClientConfig.LimbMessages == "Unique" && npcLimbs[npc.type] is LocalizedText message)
+			if (BossChecklist.FeatureConfig.LimbMessages == "Unique" && npcLimbs[npc.type] is LocalizedText message)
 				return message;
 
-			if (BossChecklist.ClientConfig.LimbMessages != "Disabled") {
+			if (BossChecklist.FeatureConfig.LimbMessages != "Disabled") {
 				string specialCase = (npc.type == NPCID.SkeletronHand || npc.type == NPCID.MoonLordHead) ? new NPCDefinition(npc.type).Name : "";
 				return Language.GetText($"{NPCAssist.LangChat}.Defeated.Generic" + specialCase);
 			}

Localization/TranslationsNeeded.txt

@@ -1,9 +1,9 @@
-en-US, 311/311, 100%, missing 0
-de-DE, 0/311, 0%, missing 311
-it-IT, 0/311, 0%, missing 311
-fr-FR, 0/311, 0%, missing 311
-es-ES, 82/311, 26%, missing 229
-ru-RU, 269/311, 86%, missing 42
-zh-Hans, 308/311, 99%, missing 3
-pt-BR, 61/311, 20%, missing 250
-pl-PL, 0/311, 0%, missing 311
+en-US, 302/302, 100%, missing 0
+de-DE, 0/302, 0%, missing 302
+it-IT, 0/302, 0%, missing 302
+fr-FR, 0/302, 0%, missing 302
+es-ES, 80/302, 26%, missing 222
+ru-RU, 260/302, 86%, missing 42
+zh-Hans, 299/302, 99%, missing 3
+pt-BR, 61/302, 20%, missing 241
+pl-PL, 0/302, 0%, missing 302

Localization/de-DE.hjson

@@ -316,6 +316,11 @@ Mods: {
 		}
 
 		Configs: {
+			Common: {
+				// InvalidChange: You cannot change this config while {0} is active!
+				// HostChange: Only the host is allowed to change this config.
+			}
+
 			BossLogConfiguration: {
 				// DisplayName: Boss Log Customization
 
@@ -531,7 +536,7 @@ Mods: {
 				}
 			}
 
-			ClientConfiguration: {
+			FeatureConfiguration: {
 				// DisplayName: Other features
 
 				Headers: {
@@ -609,22 +614,22 @@ Mods: {
 					// Tooltip: If enabled, the last 3 seconds of your respawn time will have sound indicators.
 				}
 
-				TreasureBags: {
+				TreasureBagsOnMap: {
 					// Label: Treasure bags display on the map
 					// Tooltip: ""
 				}
 
-				Fragments: {
+				FragmentsOnMap: {
 					// Label: Fragments display on the map
 					// Tooltip: ""
 				}
 
-				Scales: {
+				ScalesOnMap: {
 					// Label: Shadow Scales and Tissue Samples display on the map
 					// Tooltip: ""
 				}
 
-				BossRadar: {
+				EnableBossRadar: {
 					// Label: Enable Boss Radar
 					// Tooltip: ""
 				}
@@ -644,40 +649,6 @@ Mods: {
 					// Tooltip: The selected NPCs will not be tracked by the radar.
 				}
 			}
-
-			DebugConfiguration: {
-				// DisplayName: Debug Interface
-
-				Headers: {
-					// Debug: "[i:3625] [c/ffeb6e:Mod Developer Tools]"
-					// DebugRecordTracker: "[i:3619] [c/ffeb6e:Record Tracker Debug Tools]"
-					// DebugResetData: "[i:575] [c/ffeb6e:Reset Data Options]"
-					// FeatureTesting: "[i:2172] [c/ffeb6e:Feature Testing]"
-				}
-
-				RecordFeatureTesting: {
-					// Label: Disable 'Boss Record' feature testing
-					/* Tooltip:
-						'''
-						Prevents Boss Records code from running, effectively disabling it while its in feature testing.
-						This feature will need testing and bug reports before its taken out of feature testing and fully enabled across all users.
-						''' */
-				}
-
-				WorldRecordFeatureTesting: {
-					// Label: Disable 'World Record' feature testing
-					/* Tooltip:
-						'''
-						Prevents World Records code from running, effectively disabling it while its in feature testing.
-						As of now this feature is known to not work and may cause issues.
-						''' */
-				}
-			}
-
-			Common: {
-				// InvalidChange: You cannot change this config while {0} is active!
-				// HostChange: Only the host is allowed to change this config.
-			}
 		}
 	}
 }

Localization/en-US.hjson

@@ -316,6 +316,11 @@ Mods: {
 		}
 
 		Configs: {
+			Common: {
+				InvalidChange: You cannot change this config while {0} is active!
+				HostChange: Only the host is allowed to change this config.
+			}
+
 			BossLogConfiguration: {
 				DisplayName: Boss Log Customization
 
@@ -531,7 +536,7 @@ Mods: {
 				}
 			}
 
-			ClientConfiguration: {
+			FeatureConfiguration: {
 				DisplayName: Other features
 
 				Headers: {
@@ -609,22 +614,22 @@ Mods: {
 					Tooltip: If enabled, the last 3 seconds of your respawn time will have sound indicators.
 				}
 
-				TreasureBags: {
+				TreasureBagsOnMap: {
 					Label: Treasure bags display on the map
 					Tooltip: ""
 				}
 
-				Fragments: {
+				FragmentsOnMap: {
 					Label: Fragments display on the map
 					Tooltip: ""
 				}
 
-				Scales: {
+				ScalesOnMap: {
 					Label: Shadow Scales and Tissue Samples display on the map
 					Tooltip: ""
 				}
 
-				BossRadar: {
+				EnableBossRadar: {
 					Label: Enable Boss Radar
 					Tooltip: ""
 				}
@@ -644,40 +649,6 @@ Mods: {
 					Tooltip: The selected NPCs will not be tracked by the radar.
 				}
 			}
-
-			DebugConfiguration: {
-				DisplayName: Debug Interface
-
-				Headers: {
-					Debug: "[i:3625] [c/ffeb6e:Mod Developer Tools]"
-					DebugRecordTracker: "[i:3619] [c/ffeb6e:Record Tracker Debug Tools]"
-					DebugResetData: "[i:575] [c/ffeb6e:Reset Data Options]"
-					FeatureTesting: "[i:2172] [c/ffeb6e:Feature Testing]"
-				}
-
-				RecordFeatureTesting: {
-					Label: Disable 'Boss Record' feature testing
-					Tooltip:
-						'''
-						Prevents Boss Records code from running, effectively disabling it while its in feature testing.
-						This feature will need testing and bug reports before its taken out of feature testing and fully enabled across all users.
-						'''
-				}
-
-				WorldRecordFeatureTesting: {
-					Label: Disable 'World Record' feature testing
-					Tooltip:
-						'''
-						Prevents World Records code from running, effectively disabling it while its in feature testing.
-						As of now this feature is known to not work and may cause issues.
-						'''
-				}
-			}
-
-			Common: {
-				InvalidChange: You cannot change this config while {0} is active!
-				HostChange: Only the host is allowed to change this config.
-			}
 		}
 	}
 }