Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched curly braces cause failure to read any subsequent entries #9833

Open
2 tasks done
dowobeha opened this issue May 1, 2023 · 1 comment
Open
2 tasks done
Assignees
Milestone

Comments

@dowobeha
Copy link

dowobeha commented May 1, 2023

JabRef version

5.9 (latest release)

Operating system

macOS

Details on version and operating system

macOS 13.3.1

Checked with the latest development build

  • I made a backup of my libraries before testing the latest development version.
  • I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

  1. Open a bib file that contains an entry with mismatched curly braces:
(accuracy of multilingual models by 3 to 15{{\%}.
  1. Only entries prior to the mismatched curly braces are read.

Appendix

...

Log File
Paste an excerpt of your log file here
@koppor
Copy link
Member

koppor commented May 2, 2023

Yeah, unfortunately, this is how our parser works.

A fix would go in somewhere near https://github.com/JabRef/jabref/blob/57048c17a296d301bf538f7d98a7c17940e64b07/src/main/java/org/jabref/logic/importer/fileformat/BibtexParser.java#LL912C16-L912C16

Maybe, you have some time to dive into this? We have a number of test cases ensuring that the other parsing behavior is still working.

This is a follow-up to #9668.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Normal priority
Development

No branches or pull requests

3 participants