-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latex2Unicode should parse journal macros from ADS/Harvard #2999
Comments
I disagree. The problem is that the ADS system produces invalid BibTeX, i.e. code with macros that can only be read when you use their packages. They have quite a lot of custom macros for journals, see: http://adsabs.harvard.edu/abs_doc/aas_macros.html From the point of view of data portability this is terrible. They should much rather just have included the journal names. JabRef is a general purpose BibTeX manager. I am opposed to implementing a workaround for one particular type of sources and we've decided against this for other sources on multiple occasions. Also, such a workaround would degenerate performance even further. The only option I can see is to ask @tomtung if there's a potential of changing the converter or making it a little more configurable. Right now, unknown latex commands are simply eliminated. It might be a compromise if the converter could be configured to keep them instead. |
In principle, I don't see any reason why we shouldn't support latex commands from other packages. It is just time that someone of us has to invest and create a PR. In the end, the corresponding commands only have to be added in the conversation map https://github.com/tomtung/latex2unicode/blob/master/src/main/scala/com/github/tomtung/latex2unicode/helper/Escape.scala. However, I don't think that one of the core developers have time right now for this and thus I'll put this issue on hold. |
ADS is the default database in the astronomical community. I asked my colleagues how they deal with this issue, and those who use JabRef answered: "I am still using 2.11 because of this issue." The behaviour in 2.11 is that the macro is just displayed in the journal name field. I don't know why this is not the case anymore or what is preventing you from adding an option to display this issue, but this reason basically forces astronomers to still use the older version. |
Thanks, I will have a go at this. Indeed, I have a complete set of the ADS Journal Abbreviations macros here: http://cdsads.u-strasbg.fr/abs_doc/aas_macros.sty Now we have to take a decision. In the contemporary astronomical literature journals are often abbreviated (e.g. MNRAS instead of Monthly Notices of the Astronomical Society). |
@tobiasdiez can you re-open this and assign it to me? And can we change the title of the bug "Latex2Unicode should parse journal macros from ADS/Harvard"? |
Nice to hear that you are working on it! I can't assign the issue to you since it is your first contribution. I would prefer the long un-abbreviated journal title. We may add a feature in the future that allows for a consistent display of un-abbreviated or abbreviated journal titles (we already have a pretty huge list). Then it is better to have the complete name instead of a possibly ambiguous abbreviation. |
Hey, so I was checking into this again. I don't think the file https://github.com/tomtung/latex2unicode/blob/master/src/main/scala/com/github/tomtung/latex2unicode/helper/Escape.scala is where the journal macros should go. Maybe @tomtung should comment on this? |
Issue still not resolved.
…On Thu, Dec 31, 2020, 16:50 github-actions[bot] ***@***.***> wrote:
This issue has been inactive for half a year. Since JabRef is constantly
evolving this issue may not be relevant any longer and it will be closed in
two weeks if no further activity occurs.
As part of an effort to ensure that the JabRef team is focusing on
important and valid issues, we would like to ask if you could update the
issue if it still persists. This could be in the following form:
- If there has been a longer discussion, add a short summary of the
most important points as a new comment (if not yet existing).
- Provide further steps or information on how to reproduce this issue.
- Upvote the initial post if you like to see it implemented soon.
Votes are not the only metric that we use to determine the requests that
are implemented, however, they do factor into our decision-making process.
- If all information is provided and still up-to-date, then just add a
short comment that the issue is still relevant.
Thank you for your contribution!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2999 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABD4RFWHBZO7GHR2YJRJZUDSXTIXTANCNFSM4DSWE3ZA>
.
|
Not sure whether we have to add an exclusion list or the Latex2Unicode converter itself.
http://discourse.jabref.org/t/ads-harvard-entries-contain-latex-commands-leading-to-a-blank-field-in-list-view/685
The text was updated successfully, but these errors were encountered: