Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposed enhancement: Search for groups #1904

Closed
AEgit opened this issue Sep 1, 2016 · 14 comments
Closed

Proposed enhancement: Search for groups #1904

AEgit opened this issue Sep 1, 2016 · 14 comments
Assignees
@tobiasdiez
Labels
component: groups [outdated] type: enhancement

Comments

@AEgit
Copy link

AEgit commented Sep 1, 2016

I propose to add a search functionality just for groups (unfortunately my Java knowledge is nearly non-existent, so I can only propose this, but not contribute). For large databases with many groups (I have >900 groups) it is a bit of a hassle having to scroll to the group of interest. It would be nice to have a search feature (similar to what is already available articles) just for groups. When searching for a group you could then immediately hop to the group of interest, instead of having to scroll to it.
@Siedlerchr
Copy link
Member

@oscargus Relates to #1876, Is there a "group" pseudo field already?

@oscargus
Copy link
Contributor

oscargus commented Sep 1, 2016

One can search for groups=xxx in the normal search and that will highlight/filter the entries in that group.

@AEgit Is that enough or do you mean having a search box in the groups side panel to easily filter out groups there? (Which I think is a quite reasonable way to implement it.)

@AEgit
Copy link
Author

AEgit commented Sep 1, 2016

@oscargus

I was thinking about a search box in the groups sides panel - the issue with filtering is, that you still have to scroll in the group side panel, if you want to see the actual group (not just the articles entries associated with the group). Reason for this could be, that you want to assign the group to another group (as a subgroup) - currently that can only be done by scrolling to the actual group.

Furthermore, by filtering you are not able to see entries, that are part of a subgroup of the group that you are searching for.

So, if it is possible, I would really appreciate to see an additional search box in groups side panel to filter out groups.

@tobiasdiez tobiasdiez self-assigned this Sep 1, 2016
@tobiasdiez
Copy link
Member

Good idea!
I think, I'll try to implement it during the redesign of the groups interface (work-in-progress, #1438).

@AEgit AEgit mentioned this issue Nov 11, 2016
Closed
3 tasks
@AEgit
Copy link
Author

AEgit commented Nov 21, 2016

Now that version 3.7 has been released, could we reopen this please? I would still be very interested in this functionality, and, as far as I can tell, the redesign of the groups interface (#1438) is currently on hold, so there might be other options to implement this?

@matthiasgeiger
Copy link
Member

This is quite some effort. And as the new interface will eventually replace the current one, we won't implement it for now as we would have to implement it twice, which is not really reasonable with our limited resources.

@AEgit
Copy link
Author

AEgit commented Nov 21, 2016

Hmmm, ok - could we then reopen "Groups JavaFX Rework" thread (#1438)? I just want to make sure that this problem is not forgotten. Or do people remember this issue, even when it's closed?

@tobiasdiez
Copy link
Member

We remember everything! 😄
Just kidding. Of course we sometimes forget open issues and get a reminder - it also helps motivation to work on these things.
So let me give you an idea about the timeline for this issue:

  • First we have to switch to the new ui-technology (called "JavaFX"). Progress is tracked at Integrate Javafx into master #2290. Once this is done, we reopen every issue tagged with "after-migration-to-javafx".
  • Then we will implement the rest of the groups interface and so finish [WIP] Groups JavaFX Rework #1438.
  • Finally, we have can implement new features as search for groups etc.

@AEgit
Copy link
Author

AEgit commented Nov 21, 2016

Thank you very much! All right, so I'll just follow #2290 and be excited about every progress made there :D

Would it help, if I were to install the JavaFX branch and report some bugs I would encounter? Or would this just clog up the issues reported here for the Master branch?

@koppor
Copy link
Member

koppor commented Nov 21, 2016

I think, currently, the most help is to point people to https://donations.jabref.org. Then we will hopefully have money to pay someone to implement that. Seeing the 180 open issues at https://github.com/JabRef/jabref/issues, the 121 open issues at https://github.com/koppor/jabref/issues

We can also put Supporter in place to encourage continuous finding of a supporting workforce. This only makes sense, if 10 or more people donate regularly.

Support

@AEgit AEgit mentioned this issue Dec 21, 2016
Closed
@tobiasdiez tobiasdiez reopened this Feb 24, 2017
tobiasdiez added a commit that referenced this issue Feb 24, 2017
@tobiasdiez
Implement #1904: filter groups
1ce6c32
@tobiasdiez tobiasdiez mentioned this issue Feb 24, 2017
Merged
6 tasks
@AEgit AEgit mentioned this issue Mar 1, 2017
Closed
lenhard pushed a commit that referenced this issue Mar 2, 2017
@tobiasdiez @lenhard
Implement #1904: filter groups (#2588)
48f5293
Siedlerchr added a commit that referenced this issue Mar 2, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into moveFileDir
c0f60e0 
* upstream/master: (21 commits)
  Implement #1904: filter groups (#2588)
  Braces checking followup (#2598)
  Improve braces checking (#2593)
  Fix pdf file import when only one file selected and no entry created (#2592)
  Fix test
  Imports
  Localization: MainFile: French: update (#2591)
  isPdf helper method
  Add asString with UTF-8 as standard encoding
  Fix names of groups in "add/move to group" dialog
  Make automatic groups a first-class citizien (#2563)
  Rename downloadToString method to asString
  Refactoring method names
  Inline Mime type detection
  Fix imports
  Extract SSL bypassing
  Bypass SSL functionality
  Unused methods and refactoring
  Always use browser user agent
  Monitored URLDownload is currently not use anywhere
  ...

# Conflicts:
#	CHANGELOG.md
tobiasdiez added a commit that referenced this issue Mar 3, 2017
@tobiasdiez
Implement #1904: filter groups
22c75d1
@tobiasdiez
Copy link
Member

This is implemented in the latest development version. Could you please check the build from http://builds.jabref.org/master/. Thanks!

tobiasdiez added a commit that referenced this issue Mar 3, 2017
@tobiasdiez
Add "Remove group and subgroups" option (#2587)
79ff330 
* Add "Remove group and subgroups" option
Issue #1407 is fixed in the process

* Remove old code

* Implement #1904: filter groups

* Entries are filtered again correctly
@AEgit
Copy link
Author

AEgit commented Mar 3, 2017

The search feature does appear in the groups panel. The performance, however, is currently to low for my large database to assess whether it works or not: When I insert one character, JabRef uses 100% of the CPU power and the RAM consumption is also growing to 6 GB (after which I killed the process, so maybe even more), but nothing is found is within a couple of minutes. I guess this related to the problems mentioned here: #2599

Once these issues are solved, the new search feature will be a great help for my work! Thank you very much!

@tobiasdiez tobiasdiez mentioned this issue Mar 4, 2017
Closed
29 tasks
@tobiasdiez
Copy link
Member

tobiasdiez commented Mar 4, 2017 •
edited
Loading

Thanks for the feedback! I can reproduce the really bad performance for you db. I will try to improve the performance after everything else works. Lets keep this issue closed and #2599 tracks the performance issue.

@AEgit
Copy link
Author

AEgit commented Mar 4, 2017

Thank you very much for your help!

Siedlerchr added a commit that referenced this issue Mar 7, 2017
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into showProgressAtButton
8fc64fc 
* upstream/master: (91 commits)
  fixed #2613 (#2623)
  Add MathSciNet as ID-based fetcher (#2621)
  Add icon + color and description to groups (#2612)
  Fixed wrong logger import (#2618)
  Cleanup window has a scrollbar now. (#2614)
  Added the locale to a newly created class
  Move ExportComparator and CustomExportList to the correct package (only used in preferences)
  Fixes displaying of Mr DLib recommendations (#2616)
  Fix title-related key patterns in BibtexKeyPatternUtil (#2610)
  Remove OrdinalsToSuperscriptFormatter from recommended biblatex save actions (#2601)
  Update pgjdbc to new major version
  Update Dependenices String Similary log4j wiremock mockito
  Fix exception when parsing groups which contain a top level group (#2611)
  Add "Remove group and subgroups" option (#2587)
  Fix #1104: group selection is preserved under tab change
  Fix several File Cleanup + Rename issues  (#2415)
  Fixed a small error in the code comments
  Implement #1904: filter groups (#2588)
  Braces checking followup (#2598)
  Improve braces checking (#2593)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tobiasdiez tobiasdiez

Labels
component: groups [outdated] type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Siedlerchr @matthiasgeiger @koppor @tobiasdiez @oscargus @AEgit