Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group search should be OR - not AND #12721

Open
koppor opened this issue Mar 12, 2025 · 15 comments
Open

Group search should be OR - not AND #12721

koppor opened this issue Mar 12, 2025 · 15 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: groups good fourth issue 📌 Pinned

Comments

@koppor
Copy link
Member

koppor commented Mar 12, 2025

Context: JabRef groups - see https://docs.jabref.org/finding-sorting-and-cleaning-entries/groups for a longer explanation.

One can search for groups in the side pane. When entering two group names separated by a space, JabRef should match group strings containing any of these words. (Currently, it requires ALL words to be present)

Image

Task:

  • Investigate if Search.g4 can be used here, too.
  • Re-implement the search using that grammar here

Refs #10209 somehow

@techaakritisha
Copy link

Hello @koppor I am Akriti . I would love to work on this issue . Can you Please assigned it to me .

Copy link
Contributor

👋 Hey @techaakritisha, looks like you’re eager to work on this issue—great! 🎉 It also looks like you skipped reading our CONTRIBUTING.md, which explains exactly how to participate. No worries, it happens to the best of us. Give it a read, and you’ll discover the ancient wisdom of assigning issues to yourself. Trust me, it’s worth it. 🚀

@techaakritisha
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 15, 2025
Copy link
Contributor

👋 Hey @techaakritisha, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 29 April 2025). A maintainer can also add the "📌 Pinned" label to prevent automatic unassignment.

@subhramit
Copy link
Member

Hello @koppor I am Akriti . I would love to work on this issue . Can you Please assigned it to me .

Hey, although you are free to give it a go, note that this issue is not intended for newcomers (see the good "fourth" issue label).

Copy link
Contributor

⚠️ Issue Already Assigned

Hi @subhramit, this issue is currently assigned to @techaakritisha.

Note

If no progress is made within ** days**, the issue will be automatically unassigned.

Options for contributors
  • Wait for availability: The issue may become available if auto-unassigned
  • Collaborate: You can ask @techaakritisha if they want help
  • Maintainer assistance: A maintainer can add you as co-assignee if appropriate

@subhramit
Copy link
Member

⚠️ Issue Already Assigned

Hi @subhramit, this issue is currently assigned to @techaakritisha.

Note

If no progress is made within ** days**, the issue will be automatically unassigned.

Options for contributors

@koppor (i) i think we need to be excluded (ii) number of days seems broken

@techaakritisha
Copy link

Hey @subhramit @koppor I am working on it . "Please give me some time as this is an good fourth issue. It is taking time to understand it clearly.

@techaakritisha
Copy link

techaakritisha commented Mar 18, 2025

unassign-me

@koppor
Copy link
Member Author

koppor commented Mar 18, 2025

/unassign @techaakritisha

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 18, 2025
@Sak-drago
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 18, 2025
Copy link
Contributor

👋 Hey @Sak-drago, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if there is not a (draft) pull request within 14 days (by 01 April 2025).

@Sak-drago
Copy link

Working on it. Will keep posting updates as ideas or implementations come by.

@subhramit
Copy link
Member

Hey, although you are free to give it a go, note that this issue is not intended for newcomers (see the good "fourth" issue label).

@Sak-drago please note as well. Feel free to take it (if you are experienced in this context), or you can start with something simpler.

@Sak-drago
Copy link

If any doubts, I will let you or the team know. I have decent lot experience with Java. Let's see how this goes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: groups good fourth issue 📌 Pinned
Projects
None yet
Development

No branches or pull requests

4 participants