Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag'n'drop of PDF does nothing #12561

Open
koppor opened this issue Feb 24, 2025 · 4 comments
Open

Drag'n'drop of PDF does nothing #12561

koppor opened this issue Feb 24, 2025 · 4 comments
Assignees
Labels
good second issue Issues that involve a tour of two or three interweaved components in JabRef 📌 Pinned

Comments

@koppor
Copy link
Member

koppor commented Feb 24, 2025

Illustration

  1. Start JabRef
  2. Open test-library-with-attached-files.bib contained in src\test\resources\org\jabref\logic\search.
  3. Select entry minimal-sentence-case
  4. Change citation key to "x"
  5. Navigate to tab "General"
  6. Drag and drop "minimal-note-all-upper-case.pdf" to the "File" box
  7. See that nothing happens

Image

Expected behavior:

  • File already linked: There should be a notification (dialogservice.notify(...)) that the file is already linked in the library and thus is not relinked
  • File not already linked: Link the file

Note: This is kind of detective work

Drag and drop onto the entry in the main table works.

Image

@koppor koppor added the good second issue Issues that involve a tour of two or three interweaved components in JabRef label Feb 24, 2025
@koppor koppor changed the title Drag'n'drop of PDF does nothing if file already linked Drag'n'drop of PDF does nothing Feb 24, 2025
@GriffinCostello
Copy link

Hey I would like to work on this

@subhramit
Copy link
Member

subhramit commented Mar 1, 2025

Hey I would like to work on this

please use the assignment action mentioned in contributing docs to be assigned to the issue. You can also look at other issues on how it's done.

I'll assign you on this one.

@subhramit
Copy link
Member

/assign @GriffinCostello

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 1, 2025
Copy link
Contributor

github-actions bot commented Mar 1, 2025

👋 Hey @GriffinCostello, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 15 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 17, 2025
@JabRef JabRef deleted a comment from github-actions bot Mar 17, 2025
@JabRef JabRef deleted a comment from GriffinCostello Mar 17, 2025
@JabRef JabRef deleted a comment from github-actions bot Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good second issue Issues that involve a tour of two or three interweaved components in JabRef 📌 Pinned
Projects
None yet
Development

No branches or pull requests

3 participants