Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Search for unlinked local files" for new library #12558

Open
koppor opened this issue Feb 24, 2025 · 10 comments · May be fixed by #12738
Open

Disable "Search for unlinked local files" for new library #12558

koppor opened this issue Feb 24, 2025 · 10 comments · May be fixed by #12738
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned

Comments

@koppor
Copy link
Member

koppor commented Feb 24, 2025

  1. Start JabRef
  2. Create new library
  3. DO NOT SAVE
  4. Open "Lookup" menu
  5. See that "Search for unlinked local files" is clickable

The action "Search for unlinked local files" should only run if the current library is saved (so that the path of the .bib file is known).


Hint: Look at https://github.com/JabRef/jabref/pull/12199/files for code hints.

This is a follow-up to #11920

@koppor koppor added component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Feb 24, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 24, 2025
@raquelgraos
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Feb 27, 2025
Copy link
Contributor

👋 Hey @raquelgraos, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if the issue isn't closed within 45 days (by 13 April 2025). A maintainer can also add the "📌 Pinned"" label to prevent automatic unassignment.

@subhramit subhramit moved this from Free to take to Assigned in Good First Issues Mar 11, 2025
raquelgraos added a commit to raquelgraos/jabref that referenced this issue Mar 12, 2025
Disables the option to "Search for unlinked local files" in the Lookup menu before the newly created library is saved as the action should only be available when the .bib file path is known.
Fixes: JabRef#12558
raquelgraos added a commit to raquelgraos/jabref that referenced this issue Mar 12, 2025
Disables the option to "Search for unlinked local files" in the Lookup menu before the newly created library is saved as the action should only be available when the .bib file path is known.
Fixes JabRef#12558
raquelgraos added a commit to raquelgraos/jabref that referenced this issue Mar 12, 2025
Disables the option to "Search for unlinked local files"
in the Lookup menu before the newly created library is
saved as the action shold only be available when the
.bib file path is known
Fixes JabRef#12558
@koppor koppor moved this from Assigned to In Progress in Good First Issues Mar 13, 2025
@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 17, 2025
Copy link
Contributor

📋 Assignment Update

Hi @raquelgraos, you are no longer assigned to this issue.

Next steps

If you still want to work on this:

  • Comment with /assign-me to request reassignment
  • Ask a maintainer to assign you again
  • If you're making progress, a maintainer can add the pin label to prevent future automatic unassignment

@raquelgraos
Copy link

/assign-me

Copy link
Contributor

⚠️ Reassignment Blocked

Hi @raquelgraos, you cannot assign yourself to this issue again.

Note

Since you were previously unassigned from this issue, a maintainer needs to approve your reassignment.

Please ask a maintainer to assign you if you'd like to continue working on this issue.

@raquelgraos
Copy link

Hi @subhramit, could you please reassign me the issue?

Thanks!

Copy link
Contributor

👋 Hey @raquelgraos, looks like you’re eager to work on this issue—great! 🎉 It also looks like you skipped reading our CONTRIBUTING.md, which explains exactly how to participate. No worries, it happens to the best of us. Give it a read, and you’ll discover the ancient wisdom of assigning issues to yourself. Trust me, it’s worth it. 🚀

@subhramit
Copy link
Member

@raquelgraos Hey, sorry - unsure why that happened.
We are testing out a lot of automated workflows so could be a side effect.

@raquelgraos
Copy link

That's ok! Thank you for the reassignment!

@koppor
Copy link
Member Author

koppor commented Mar 17, 2025

We were working on our workflows for unassignment. Should not happen in future (because of the Pinned label)

@subhramit subhramit added 📍 Assigned Assigned by assign-issue-action (or manually assigned) 📌 Pinned and removed 📌 Pinned labels Mar 18, 2025
@koppor koppor moved this from In Progress to Assigned in Good First Issues Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: ui good first issue An issue intended for project-newcomers. Varies in difficulty. 📌 Pinned
Projects
Status: Assigned
Development

Successfully merging a pull request may close this issue.

3 participants