Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web import: New entry should be added to group "Imported entries" #12548

Open
koppor opened this issue Feb 23, 2025 · 13 comments
Open

Web import: New entry should be added to group "Imported entries" #12548

koppor opened this issue Feb 23, 2025 · 13 comments
Assignees
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: fetcher component: groups component: import-load good first issue An issue intended for project-newcomers. Varies in difficulty.

Comments

@koppor
Copy link
Member

koppor commented Feb 23, 2025

As user, I want to know which entries I did import the last times. It is possible to check for the last added entry (https://docs.jabref.org/advanced/entryeditor/timestamp).

After an import, the last imported entry is highlighted. If I import multiple entries, only the last one is highlighted. If I repeatedly import entries.

As user, I have two phases: Searching and importing entries; and clean up of entries. For cleanup, I need to know which entries need clean up. I mix between web search and PDF import.

After an import, some tweaks in the bibliographic entries need to be done: Fix of authors, fix of titles. E.g., by applying Integrity Checks. Not all of them are "right" and need to be manually checked.

Another use case for marking imported entries is that they are kind of papers one wants to read.

Therefore, JabRef should automatically add entries to a group "Imported entries".

Desired feature

  • After web search, new entries should be added to the group "Imported entries". The group name can be changed in the preferences:
  • After a PDF is imported, it should also be added to this group
  • After importing from DOI or other web fetchers, it should also be added to this group
  • The feature should only be enabled if enabled in the preferences
  • The name of the group should be (globally) configurable

Details

Enable configuring the group to add to:

Image

Code hints

  • org.jabref.gui.externalfiles.ImportHandler#importEntryWithDuplicateCheck(org.jabref.model.database.BibDatabaseContext, org.jabref.model.entry.BibEntry, org.jabref.gui.duplicationFinder.DuplicateResolverDialog.DuplicateResolverResult)
  • Store % Imported entries in the preferences.
    • In the preference defaults, store "% " + Localization.lang("Imported entries")
    • When getting the preference, check whether the string begins with %. If yes. Remove % and the space after and lookup using Localization.lang.

References

@koppor koppor added the good first issue An issue intended for project-newcomers. Varies in difficulty. label Feb 23, 2025
@github-project-automation github-project-automation bot moved this to Free to take in Good First Issues Feb 23, 2025
@ThiloteE
Copy link
Member

ThiloteE commented Feb 23, 2025

Is #8836 considered? Is there a way to work around it?
Also competes with #7871

@Stargazer10101
Copy link

/assign-me

@Stargazer10101
Copy link

@subhramit I have already started working on this issue and made progress as well. Kindly assign this to me.

@subhramit
Copy link
Member

The assign action should be fixed after #12616.
I'll manually assign you for now.

@subhramit subhramit moved this from Free to take to Assigned in Good First Issues Mar 4, 2025
@koppor koppor moved this from Assigned to Free to take in Good First Issues Mar 4, 2025
@subhramit subhramit added the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Welcome to the vibrant world of open-source development with JabRef!

Newcomers, we're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

⚠ Note that this issue will become unassigned if it isn't closed within 30 days.

🔧 A maintainer can also add the Pinned label to prevent it from being unassigned automatically.

Happy coding! 🚀

@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 4, 2025
@koppor
Copy link
Member Author

koppor commented Mar 4, 2025

Is #8836 considered?

I think you mean #8836 (comment) maybe?

Also competes with #7871

IMHO they complement each other. #7871 is about entries without group and this one is about adding to a groups automatically.

@koppor koppor moved this from Assigned to Free to take in Good First Issues Mar 4, 2025
@koppor koppor added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 6, 2025
@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 6, 2025
@koppor koppor removed the FirstTimeCodeContribution Triggers GitHub Greeter Workflow label Mar 6, 2025
@Stargazer10101
Copy link

How fast am I expected to complete this? You may unassign me because I am caught up in college evaluations. I have made some progress and I'll directly open a PR and ask you to assign me. Apologies for any trouble caused.

@subhramit
Copy link
Member

subhramit commented Mar 6, 2025

How fast am I expected to complete this? You may unassign me because I am caught up in college evaluations.

There is no hard and fast time window, but the general expectation for a good first issue would be up to two weeks for someone with pre-requisite knowledge of Java as per a first degree university student curriculum or equivalent.

I'll directly open a PR and ask you to assign me.

If by the time you open a PR nobody else is assigned, we can assign you and only then accept your contribution. Otherwise, you can take up some other issue later as well. If you wish to be un-assigned, use the unassign-me action.

@Stargazer10101
Copy link

There is no hard and fast time window, but the general expectation for a good first issue would be up to two weeks for someone with pre-requisite knowledge of Java as per a first degree university student curriculum or equivalent.

Alright! I'll be able to do it.

@github-actions github-actions bot removed the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 22, 2025
Copy link
Contributor

📋 Assignment Update

Hi @Stargazer10101, due to inactivity, you have been unassigned from this issue.

Next steps

If you still want to work on this:

  • Ask a maintainer to assign you again
  • If you're making progress, a maintainer can add the pin label to prevent future automatic unassignment

@koppor koppor moved this from Assigned to Free to take in Good First Issues Mar 22, 2025
@Sak-drago
Copy link

@koppor taking up this too since it should not be that big of a deal. Will deliver this one by 5 April.

@Sak-drago
Copy link

/assign-me

@github-actions github-actions bot added the 📍 Assigned Assigned by assign-issue-action (or manually assigned) label Mar 24, 2025
Copy link
Contributor

👋 Hey @Sak-drago, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

⏳ Please note, you will be automatically unassigned if there is not a (draft) pull request within 14 days (by 07 April 2025).

@koppor koppor moved this from Free to take to Assigned in Good First Issues Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📍 Assigned Assigned by assign-issue-action (or manually assigned) component: fetcher component: groups component: import-load good first issue An issue intended for project-newcomers. Varies in difficulty.
Projects
Status: Assigned
Development

No branches or pull requests

6 participants