Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create proper event bubbling #12353

Open
tobiasdiez opened this issue Apr 10, 2018 · 3 comments
Open

Create proper event bubbling #12353

tobiasdiez opened this issue Apr 10, 2018 · 3 comments
Labels
dev: code-quality Issues related to code or architecture decisions

Comments

@tobiasdiez
Copy link
Member

Event bubbling already works for keyboard shortcuts, but not yet for actions performed through the menu. For example, when invoking "Copy" when the focus is on the entry preview, the preview should be copied to the clipboard and not the bibtex code of the entry.

Maybe helpful:

@koppor koppor added the dev: code-quality Issues related to code or architecture decisions label Jan 4, 2025
@koppor koppor transferred this issue from JabRef/jabref-koppor Jan 4, 2025
@github-project-automation github-project-automation bot moved this to Normal priority in Prioritization Jan 4, 2025
@koppor koppor moved this from Normal priority to High priority in Prioritization Jan 4, 2025
@Siedlerchr
Copy link
Member

The issue is from 2018. It's missing context. Is this still relevant?

@koppor
Copy link
Member

koppor commented Jan 8, 2025

I think, we still have issues with proper copy and paste code...

@koppor koppor mentioned this issue Jan 27, 2025
7 tasks
@koppor
Copy link
Member

koppor commented Jan 27, 2025

It seems, we still have some workarounds in place:

private void setupKeyBindings(KeyBindingRepository keyBindings) {

See especially

                    // Pass other keys to parent

There is no documentation why we need this "hack" (or why this is a hack at alll - if it is not a hack, there should be JavaDoc explaining it and developer documentation existing how we handle keyboard shortcuts - and it should be linked)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev: code-quality Issues related to code or architecture decisions
Projects
Status: High priority
Development

No branches or pull requests

3 participants