Link is the only mandatory field #98

Author: stefan-kolb

src/main/java/net/sf/jabref/model/entry/FileField.java

@@ -168,6 +168,12 @@ private static FileField.ParsedFileField convert(List<String> entry) {
             entry.add("");
         }
         FileField.ParsedFileField field = new FileField.ParsedFileField(entry.get(0), entry.get(1), entry.get(2));
+        // link is only mandatory field
+        if(field.description.isEmpty() && field.link.isEmpty() && !field.fileType.isEmpty()) {
+            field = new ParsedFileField("", field.fileType, "");
+        } else if(!field.description.isEmpty() && field.link.isEmpty() && field.fileType.isEmpty()) {
+            field = new ParsedFileField("", field.description, "");
+        }
         entry.clear();
         return field;
     }

src/test/java/net/sf/jabref/model/entry/FileFieldTest.java

@@ -2,6 +2,7 @@
 
 import org.junit.Test;
 
+import java.util.Arrays;
 import java.util.Collections;
 
 import static org.junit.Assert.*;
@@ -31,6 +32,15 @@ public void ingoreMissingDescription() throws Exception {
         assertEquals(Collections.singletonList(new FileField.ParsedFileField("", "wei2005ahp.pdf", "PDF")), FileField.parse(input));
     }
 
+    @Test
+    public void interpreteLinkAsOnlyMandatoryField() throws Exception {
+        String single = "wei2005ahp.pdf";
+        String multiple = "wei2005ahp.pdf;other.pdf";
+
+        assertEquals(Collections.singletonList(new FileField.ParsedFileField("", "wei2005ahp.pdf", "")), FileField.parse(single));
+        assertEquals(Arrays.asList(new FileField.ParsedFileField("", "wei2005ahp.pdf", ""), new FileField.ParsedFileField("", "other.pdf", "")), FileField.parse(multiple));
+    }
+
     @Test
     public void escapedCharactersInDescription() throws Exception {
         String input = "test\\:\\;:wei2005ahp.pdf:PDF";
@@ -53,10 +63,14 @@ public void handleEscapedFilePath() throws Exception {
     }
 
     @Test
-    public void tooLessSeparators() throws Exception {
-        String input = "desc:";
-
-        assertEquals(Collections.singletonList(new FileField.ParsedFileField("desc", "", "")), FileField.parse(input));
+    public void subsetOfFieldsResultsInFileLink() throws Exception {
+        String descOnly = "file.pdf::";
+        String fileOnly = ":file.pdf";
+        String typeOnly = "::file.pdf";
+
+        assertEquals(Collections.singletonList(new FileField.ParsedFileField("", "file.pdf", "")), FileField.parse(descOnly));
+        assertEquals(Collections.singletonList(new FileField.ParsedFileField("", "file.pdf", "")), FileField.parse(fileOnly));
+        assertEquals(Collections.singletonList(new FileField.ParsedFileField("", "file.pdf", "")), FileField.parse(typeOnly));
     }
 
     @Test