Eliminate double Localizations for FindUnlinkedFilesDialog

Author: matthiasgeiger

src/main/java/net/sf/jabref/gui/FindUnlinkedFilesDialog.java

@@ -94,10 +94,10 @@ public class FindUnlinkedFilesDialog extends JDialog {
      * Keys to be used for referencing this Action.
      */
     public static final String ACTION_COMMAND = "findUnlinkedFiles";
-    public static final String ACTION_TITLE = Localization.lang("Find unlinked files") + "..."; // this entry is NOT in Menu_en.properties as the same string also appears in JabRef_en.properties
+    public static final String ACTION_MENU_TITLE = "Find unlinked files...";
     public static final String ACTION_ICON = "toggleSearch";
     public static final String ACTION_KEYBINDING_ACTION = "Find unlinked files";
-    public static final String ACTION_SHORT_DESCRIPTION = Localization.lang("Searches for unlinked PDF files on the file system");
+    public static final String ACTION_SHORT_DESCRIPTION = "Searches for unlinked PDF files on the file system";
 
     private static final String GLOBAL_PREFS_WORKING_DIRECTORY_KEY = "findUnlinkedFilesWD";
     private static final String GLOBAL_PREFS_DIALOG_SIZE_KEY = "findUnlinkedFilesDialogSize";

src/main/java/net/sf/jabref/gui/JabRefFrame.java

@@ -394,10 +394,10 @@ public void actionPerformed(ActionEvent e) {
     private final AbstractAction customFileTypesAction = ExternalFileTypeEditor.getAction(this);
     AbstractAction exportToClipboard = new GeneralAction("exportToClipboard", "Export selected entries to clipboard");
     private final AbstractAction autoSetPdf = new GeneralAction(Actions.AUTO_SET_PDF,
-            Localization.lang("Synchronize %0 links", "PDF"),
+            "Synchronize PDF links",
             prefs.getKey(KeyBinds.SYNCHRONIZE_PDF));
     private final AbstractAction autoSetPs = new GeneralAction(Actions.AUTO_SET_PS,
-            Localization.lang("Synchronize %0 links", "PS"),
+            "Synchronize PS links",
             prefs.getKey(KeyBinds.SYNCHRONIZE_PS));
     private final AbstractAction autoSetFile = new GeneralAction(Actions.AUTO_SET_FILE,
             Localization.lang("Synchronize file links"),
@@ -446,8 +446,8 @@ public void actionPerformed(ActionEvent e) {
 
     private final GeneralAction findUnlinkedFiles = new GeneralAction(
             FindUnlinkedFilesDialog.ACTION_COMMAND,
-            FindUnlinkedFilesDialog.ACTION_TITLE,
-            FindUnlinkedFilesDialog.ACTION_SHORT_DESCRIPTION,
+            FindUnlinkedFilesDialog.ACTION_MENU_TITLE,
+            Localization.lang(FindUnlinkedFilesDialog.ACTION_SHORT_DESCRIPTION),
             prefs.getKey(FindUnlinkedFilesDialog.ACTION_KEYBINDING_ACTION),
             IconTheme.getImage("toggleSearch")
     );