Skip to content

Commit 05de4cd

Browse files
author
whatisfahad
committed
refactor: Remove duplicate HTTP and HTTPS prefix constants in FileFieldParser
1 parent ac57447 commit 05de4cd

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/main/java/org/jabref/logic/importer/util/FileFieldParser.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,20 @@
88

99
import org.jabref.logic.util.URLUtil;
1010
import org.jabref.model.entry.LinkedFile;
11+
1112
import org.slf4j.Logger;
1213
import org.slf4j.LoggerFactory;
1314

1415
public class FileFieldParser {
1516
private static final Logger LOGGER = LoggerFactory.getLogger(FileFieldParser.class);
17+
private static final String HTTP_PREFIX = "http://";
18+
private static final String HTTPS_PREFIX = "https://";
1619

1720
private final String value;
1821

1922
private StringBuilder charactersOfCurrentElement;
2023

2124
private boolean windowsPath;
22-
private static final String HTTP_PREFIX = "http://";
23-
private static final String HTTPS_PREFIX = "https://";
2425

2526
public FileFieldParser(String value) {
2627
if (value == null) {

src/test/java/org/jabref/logic/net/URLUtilTest.java

+2-3
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,10 @@
44
import java.net.URL;
55

66
import org.jabref.logic.util.URLUtil;
7-
8-
import org.junit.jupiter.api.Test;
9-
107
import static org.junit.jupiter.api.Assertions.assertEquals;
118
import static org.junit.jupiter.api.Assertions.assertFalse;
129
import static org.junit.jupiter.api.Assertions.assertTrue;
10+
import org.junit.jupiter.api.Test;
1311

1412
class URLUtilTest {
1513

@@ -88,6 +86,7 @@ void createUriShouldHandlePipeCharacter() {
8886
URI uri = URLUtil.createUri(input);
8987
assertEquals("http://example.com/test%7Cfile", uri.toString());
9088
}
89+
9190
@Test
9291
void createShouldHandleRelativeURLs() throws Exception {
9392
URL relativeUrl = URLUtil.create("www.example.com");

0 commit comments

Comments
 (0)