Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing browser agent to determine mozPaint/Beacons/Geometry... #105

Open
seanmerrigan opened this issue Oct 26, 2015 · 0 comments
Open

Comments

@seanmerrigan
Copy link
Contributor

In a debug branch, we switched the conditional used to determine if the MozPaintCount or Flash Beacon method should be used from:
if ($ovv.browser.ID === $ovv.browserIDEnum.Firefox){
... to:
if ( !!window.mozPaintCount ) {
... and we've noticed that there are now a number of cases where the browserData.getBrowser() method claims the browser is a Firefox version that's capable of supporting MozPaintCount but the Flash beacon method is used instead. This indicates that (in the master version) the user agent parser is incorrectly identifying browsers that can't use mozPaintCount as Firefox.

Whenever possible we should check for supported properties instead of inferring them from the detected browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant