Skip to content

Commit 29fca4a

Browse files
committed
fix: unit tests warnings
1 parent 703b0d8 commit 29fca4a

File tree

3 files changed

+18
-11
lines changed

3 files changed

+18
-11
lines changed

pytest.ini

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
[pytest]
2+
markers =
3+
network: mark a test as a network.

tests/test_04_key_jar.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -1058,7 +1058,7 @@ def test_similar():
10581058

10591059
kj = KeyJar()
10601060
kb = KeyBundle(JWK2)
1061-
kj.add_kb(issuer=ISSUER, kb=kb)
1061+
kj.add_kb(issuer_id=ISSUER, kb=kb)
10621062

10631063
keys1 = kj.get_issuer_keys(ISSUER)
10641064
keys2 = kj[ISSUER].all_keys()

tests/test_50_argument_alias.py

+14-10
Original file line numberDiff line numberDiff line change
@@ -65,33 +65,35 @@ def setup(self):
6565
self.bob_keyjar["Bob"] = self.bob_keyjar[""]
6666

6767
# To Alice's keyjar add Bob's public keys
68-
self.alice_keyjar.import_jwks(self.bob_keyjar.export_jwks(issuer="Bob"), "Bob")
68+
self.alice_keyjar.import_jwks(self.bob_keyjar.export_jwks(issuer_id="Bob"), "Bob")
6969

7070
# To Bob's keyjar add Alice's public keys
71-
self.bob_keyjar.import_jwks(self.alice_keyjar.export_jwks(issuer="Alice"), "Alice")
71+
self.bob_keyjar.import_jwks(self.alice_keyjar.export_jwks(issuer_id="Alice"), "Alice")
7272

7373
_jws = JWS('{"aud": "Bob", "iss": "Alice"}', alg="RS256")
74-
sig_key = self.alice_keyjar.get_signing_key("rsa", owner="Alice")[0]
74+
sig_key = self.alice_keyjar.get_signing_key("rsa", issuer_id="Alice")[0]
7575
self.sjwt_a = _jws.sign_compact([sig_key])
7676

7777
_jws = JWS('{"aud": "Alice", "iss": "Bob"}', alg="RS256")
78-
sig_key = self.bob_keyjar.get_signing_key("rsa", owner="Bob")[0]
78+
sig_key = self.bob_keyjar.get_signing_key("rsa", issuer_id="Bob")[0]
7979
self.sjwt_b = _jws.sign_compact([sig_key])
8080

8181
def test_no_kid_multiple_keys_no_kid_issuer(self):
82-
a_kids = [k.kid for k in self.alice_keyjar.get_verify_key(owner="Alice", key_type="RSA")]
82+
a_kids = [
83+
k.kid for k in self.alice_keyjar.get_verify_key(issuer_id="Alice", key_type="RSA")
84+
]
8385
no_kid_issuer = {"Alice": a_kids}
8486
_jwt = factory(self.sjwt_a)
8587
_jwt.jwt.headers["kid"] = ""
8688
keys = self.bob_keyjar.get_jwt_verify_keys(_jwt.jwt, no_kid_issuer=no_kid_issuer)
8789
assert len(keys) == 3
8890

8991
def test_aud(self):
90-
self.alice_keyjar.import_jwks(JWK1, issuer="D")
91-
self.bob_keyjar.import_jwks(JWK1, issuer="D")
92+
self.alice_keyjar.import_jwks(JWK1, issuer_id="D")
93+
self.bob_keyjar.import_jwks(JWK1, issuer_id="D")
9294

9395
_jws = JWS('{"iss": "D", "aud": "A"}', alg="HS256")
94-
sig_key = self.alice_keyjar.get_signing_key("oct", owner="D")[0]
96+
sig_key = self.alice_keyjar.get_signing_key("oct", issuer_id="D")[0]
9597
_sjwt = _jws.sign_compact([sig_key])
9698

9799
no_kid_issuer = {"D": []}
@@ -121,7 +123,9 @@ def test_init_key_jar_dump_private():
121123
os.unlink(_file)
122124

123125
# New set of keys, JWKSs with keys and public written to file
124-
_keyjar = init_key_jar(private_path=PRIVATE_FILE, key_defs=KEYSPEC, owner="https://example.com")
126+
_keyjar = init_key_jar(
127+
private_path=PRIVATE_FILE, key_defs=KEYSPEC, issuer_id="https://example.com"
128+
)
125129
assert list(_keyjar.owners()) == ["https://example.com"]
126130

127131
# JWKS will be read from disc, not created new
@@ -138,7 +142,7 @@ def test_init_key_jar_update():
138142
_keyjar_1 = init_key_jar(
139143
private_path=PRIVATE_FILE,
140144
key_defs=KEYSPEC,
141-
owner="https://example.com",
145+
issuer_id="https://example.com",
142146
public_path=PUBLIC_FILE,
143147
read_only=False,
144148
)

0 commit comments

Comments
 (0)