Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDC Adding server to processing state table to allow the processing script to run on multiple servers #11277

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

stevenwinship
Copy link
Contributor

@stevenwinship stevenwinship commented Feb 19, 2025

What this PR does / why we need it: A server column is needed in the MDC processing state table in order to allow the processing to take place on more than one server. Counter processor needs to restart processing on the same server to take advantage of the already processed data. Also this keeps multiple servers from processing the same month's data.
Also updates needed to docs for counter_processor 1.06 release

Which issue(s) this PR closes: #11276

Special notes for your reviewer:

Suggestions on how to test this: See IT tests. Make API calls GET POST DELETE

Does this PR introduce a user interface change? If mockups are available, please link/include them here:No

Is there a release notes update needed for this change?: Included

Additional documentation:

@stevenwinship stevenwinship added Feature: Metrics + Reports Size: 3 A percentage of a sprint. 2.1 hours. FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) labels Feb 19, 2025
@stevenwinship stevenwinship self-assigned this Feb 19, 2025
@coveralls
Copy link

coveralls commented Feb 19, 2025

Coverage Status

coverage: 22.719% (-0.02%) from 22.736%
when pulling aa8beec on 11276-mdc-add-server-to-processing-state-db-table
into 2210d16 on develop.

This comment has been minimized.

1 similar comment

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Feb 20, 2025

This comment has been minimized.

@stevenwinship stevenwinship self-assigned this Feb 20, 2025

This comment has been minimized.

@stevenwinship stevenwinship removed their assignment Feb 20, 2025
@scolapasta scolapasta added this to the 6.6 milestone Feb 24, 2025

This comment has been minimized.

@@ -1,6 +1,6 @@
#! /bin/bash

COUNTER_PROCESSOR_DIRECTORY="/usr/local/counter-processor-1.05"
COUNTER_PROCESSOR_DIRECTORY="/usr/local/counter-processor-1.06"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark this PR as closing the following issue? (And take that issue off the board?)

It seems to already bump version in the docs, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I was going to ask you if the release of counter-processor 1.06 was enough to close it. Ill add the trigger to close it with this one.

@pdurbin pdurbin self-assigned this Feb 25, 2025
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test this but it seems fine. Thanks for adding the SQL script for upgrade scenarios. I'm leaving a couple minor questions in this review.

@stevenwinship stevenwinship removed their assignment Feb 25, 2025
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:11276-mdc-add-server-to-processing-state-db-table
ghcr.io/gdcc/configbaker:11276-mdc-add-server-to-processing-state-db-table

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Metrics + Reports FY25 Sprint 17 FY25 Sprint 17 (2025-02-12 - 2025-02-26) Size: 3 A percentage of a sprint. 2.1 hours.
Projects
Status: In Review 🔎
Development

Successfully merging this pull request may close these issues.

MDC: Add server to processing state db table
4 participants