-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDC Adding server to processing state table to allow the processing script to run on multiple servers #11277
base: develop
Are you sure you want to change the base?
MDC Adding server to processing state table to allow the processing script to run on multiple servers #11277
Conversation
…t to run on multiple servers
src/main/java/edu/harvard/iq/dataverse/makedatacount/MakeDataCountProcessState.java
Outdated
Show resolved
Hide resolved
src/main/java/edu/harvard/iq/dataverse/makedatacount/MakeDataCountProcessState.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/main/java/edu/harvard/iq/dataverse/makedatacount/MakeDataCountProcessState.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
@@ -1,6 +1,6 @@ | |||
#! /bin/bash | |||
|
|||
COUNTER_PROCESSOR_DIRECTORY="/usr/local/counter-processor-1.05" | |||
COUNTER_PROCESSOR_DIRECTORY="/usr/local/counter-processor-1.06" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we mark this PR as closing the following issue? (And take that issue off the board?)
It seems to already bump version in the docs, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I was going to ask you if the release of counter-processor 1.06 was enough to close it. Ill add the trigger to close it with this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test this but it seems fine. Thanks for adding the SQL script for upgrade scenarios. I'm leaving a couple minor questions in this review.
Co-authored-by: Philip Durbin <[email protected]>
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it: A server column is needed in the MDC processing state table in order to allow the processing to take place on more than one server. Counter processor needs to restart processing on the same server to take advantage of the already processed data. Also this keeps multiple servers from processing the same month's data.
Also updates needed to docs for counter_processor 1.06 release
Which issue(s) this PR closes: #11276
Special notes for your reviewer:
Suggestions on how to test this: See IT tests. Make API calls GET POST DELETE
Does this PR introduce a user interface change? If mockups are available, please link/include them here:No
Is there a release notes update needed for this change?: Included
Additional documentation: