Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After admin removes Embargo - Embargo tag still displays #11257

Open
shlake opened this issue Feb 13, 2025 · 1 comment
Open

After admin removes Embargo - Embargo tag still displays #11257

shlake opened this issue Feb 13, 2025 · 1 comment
Labels
Type: Bug a defect

Comments

@shlake
Copy link
Contributor

shlake commented Feb 13, 2025

What steps does it take to reproduce the issue?

Set an embargo. Then use the admin API command to remove the embargo. Using these commands from the guide:
https://guides.dataverse.org/en/latest/api/native-api.html#remove-an-embargo-on-files-in-a-dataset

  • When does this issue occur?
    Happens only when dataverseAdmin removes the embargo via the API unset-embargo command.

  • What happens?
    The embargo tag is still displayed on the dataset card in the collection listing, despite the file no longer having an embargo and is available to download.
    Also the embargo information for the file is not retained.

  • What did you expect to happen?
    When an embargo is removed, the "embargo" tag should also be removed.
    I also expected the file to have embargo information (that it had been embargoed). Embargo information is included on files where the software automatically releases the embargo.

Which version of Dataverse are you using?
Happens in V6.2 as well as V 6.5 (on demo.dataverse.org)

Screenshots:
Embargo tag still displaying - Seen here: https://demo.dataverse.org/dataverse/lake_design

Image

File Information for "embargoed" previously not showing when API unset-embargo is used (file from the above collection on demo.dataverse:

Image

What a previously embargoed file info looks like - after the expiration date (done automatically at expiration date):

Image

@shlake shlake added the Type: Bug a defect label Feb 13, 2025
@qqmyers
Copy link
Member

qqmyers commented Feb 13, 2025

Thanks for the report. From a quick look, there's an embargocitationdate set on a dataset that I think was added after the main embargo functionality (as a performance improvement to avoid having to look up the embargo dates on all files) that I think is the source of that label and that doesn't look like it is getting reset/deleted when an embargo is removed from a file. Not completely sure, but hopefully that provides pointers in fixing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug a defect
Projects
None yet
Development

No branches or pull requests

2 participants