-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NcML previewer not working #11252
Comments
Weird - it looks like the scripts in that dir at gdcc have not changed in two years (which makes sense as we only do updates in the betatest subdir and new releases.) Ah - I bet it got changed to use signedURLs via a config change at Harvard and this line isn't quite signedURL ready: https://github.com/gdcc/dataverse-previewers/blob/4711800f67de961ca5326e88b3e0c710a7d1301a/previewers/v1.4/js/ncml.js#L12 Workaround is to change the config for it back to using api key. My guess is that adding a line like this would fix it: https://github.com/gdcc/dataverse-previewers/blob/4711800f67de961ca5326e88b3e0c710a7d1301a/previewers/betatest/js/video.js#L13C1-L13C82 Any fix should go in the betatest dir though and the config would then need to be updated to get the new version. In any case, probably not a dataverse repo issue/no changes needed in Dataverse/not a change in Dataverse that caused it. |
I made a fix in the previewer - gdcc/dataverse-previewers@2211989. Tested on a test instance with the file listed above, both with/without signedUrls. The fix is available in the betatest version of the previewer, whereas Harvard is currently using v1.4 . As with other previewer fixes, Harvard can switch to the betatest version, download a local copy and use that, or wait for v1.5 (possibly with Dataverse v6.6?). With the code fix in the previewer repo, this is basically a https://github.com/IQSS/dataverse.harvard.edu rather than a https://github.com/IQSS issue, but I've given it a size 3 if you want to work it here. (Not sure what column now - sprint ready?) |
@qqmyers thanks! I haven't tested it but I'd suggest that we use this issue to add a release note to indicate how installations can fix this problem. That is, as you suggest, they can switch to the betatest version. Ah yeah, I suppose we should have a new issue in the prod repo to make this switch on demo and Harvard Dataverse. |
In a comment from 2023 there's a screenshot showing that the file at https://dataverse.harvard.edu/file.xhtml?fileId=6938801&datasetVersionId=340765 was being displayed properly in the NcML previewer we added a while back (see #9242). Here's how it looked back then:
Unfortunately, it's not working anymore. Now it looks like this:
The text was updated successfully, but these errors were encountered: