DOI Publishing Bug Fix #11236
Open
DOI Publishing Bug Fix #11236
+15
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenwinship
requested changes
Feb 25, 2025
src/test/java/edu/harvard/iq/dataverse/pidproviders/doi/datacite/XmlMetadataTemplateTest.java
Show resolved
Hide resolved
stevenwinship
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The code for publishing with a DOI has a bug for the case when a DOI has not been reserved prior to the publication attempt (e.g. to a prior misconfiguration/outage of DataCite, etc.). I this case, the code was finding the v1.0 added to the draft version and, due to the bug, assuming that the release was not 1.0/was an update, causing it to look for a non-existent release date and fail. The PR corrects the comparison.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: The automated test should do it, but you could misconfigure DataCite, create a dataset, and try to publish it. Before the PR it should fail, after it should succeed.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: