Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Outputs concerned by multipart issue #716 #729

Open
mdeweerd opened this issue Nov 21, 2024 · 7 comments
Open

[BUG] Outputs concerned by multipart issue #716 #729

mdeweerd opened this issue Nov 21, 2024 · 7 comments
Assignees

Comments

@mdeweerd
Copy link

In relation to #716, I found that the following outputs also suffer from the multipart selection issue:

  • STEP output;
  • 3D output (legacy) - I have not switched to blender yet;
  • Fab layers (when outputting to PDF, I guess the gerbers also suffer from this).

As a workaround for me, I'll disable the subparts splitter for now. I will enable it again in case of updates to kibot to verify the behavior.

If you want, I can update the testcase makefile to generate all the outputs.

@mdeweerd
Copy link
Author

As I've disabled the subpart splitter function, I now also notice that this is also causing a vert important performance hit.

With the subparts_filter active, generating all the outputs for one variant (a single kibot execution) took just over 50 minutes.
Without the option active, I am back down to under 5 minutes.

So that's a 10 fold performance impact.

@set-soft
Copy link
Member

So that's a 10 fold performance impact.

If you are concerned about speed: Run KiBot in separated runs, in one run generate the variants, then run KiBot without variants but using the generated PCBs/Schematics in previous run.

@set-soft
Copy link
Member

If you want, I can update the testcase makefile to generate all the outputs.

I'm currently looking at other stuff, please do it

@set-soft
Copy link
Member

To be honest I never liked the "multiparts" feature of KiCost, IMHO is dirty.
I include the "extra" components in the schematic and then I mark them as "not for the PCB".
I'll try to support some of the usage, but this will be marked as deprecated.

set-soft added a commit that referenced this issue Nov 21, 2024
set-soft added a commit that referenced this issue Nov 21, 2024
@mdeweerd
Copy link
Author

For fuse holders when there may be 3 parts:

  • The fuse holder;
  • The fuse;
  • The cap to close the fuse holder.

And all three are mounted by the PCBA contractor.

@set-soft
Copy link
Member

So what?
Why don't you just draw the fuse and the cap holder in your schematic? (marking them as not for PCB)

@set-soft
Copy link
Member

BTW: I think you should try to apply the subparts filter only to the BoM, in the local transform filter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants