-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Outputs concerned by multipart issue #716 #729
Comments
As I've disabled the subpart splitter function, I now also notice that this is also causing a vert important performance hit. With the subparts_filter active, generating all the outputs for one variant (a single kibot execution) took just over 50 minutes. So that's a 10 fold performance impact. |
If you are concerned about speed: Run KiBot in separated runs, in one run generate the variants, then run KiBot without variants but using the generated PCBs/Schematics in previous run. |
I'm currently looking at other stuff, please do it |
To be honest I never liked the "multiparts" feature of KiCost, IMHO is dirty. |
For fuse holders when there may be 3 parts:
And all three are mounted by the PCBA contractor. |
So what? |
BTW: I think you should try to apply the subparts filter only to the BoM, in the local transform filter. |
In relation to #716, I found that the following outputs also suffer from the multipart selection issue:
As a workaround for me, I'll disable the subparts splitter for now. I will enable it again in case of updates to kibot to verify the behavior.
If you want, I can update the testcase makefile to generate all the outputs.
The text was updated successfully, but these errors were encountered: