Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move allOf and oneOf resolution to getSchemaTargetGraphQLType #387

Open
Alan-Cha opened this issue Mar 30, 2021 · 1 comment
Open

Move allOf and oneOf resolution to getSchemaTargetGraphQLType #387

Alan-Cha opened this issue Mar 30, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@Alan-Cha
Copy link
Collaborator

Currently, the allOf and oneOf resolution logic is in createDataDef. However, it is better suited in getSchemaTargetGraphQLType.

There is a much more in-depth discussion in #330
@Alan-Cha Alan-Cha added enhancement New feature or request help wanted Extra attention is needed labels Mar 30, 2021
@Alan-Cha
Copy link
Collaborator Author

This change would greatly reduce the complexity in createDataDef.

@Alan-Cha Alan-Cha mentioned this issue Mar 30, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Alan-Cha