fix: check if there is a payload by checking the http method

Lionel Schiepers · Lionel Schiepers · commit 813c4a0c067d · 2020-06-15T13:28:57.000+02:00
fix: check if there is a payload by checking the http method instead of payloadRequired because that field is not always correctly initialized during unit test
diff --git a/packages/openapi-to-graphql/src/resolver_builder.ts b/packages/openapi-to-graphql/src/resolver_builder.ts
@@ -446,8 +446,12 @@ export function getResolver({
      *
      * NOTE: This may cause the user to encounter unexpected changes
      */
-    if (operation.payloadRequired)
+    if (operation.method !== 'get')
     {
+       /**
+        * the check is done on the 'get' operation to determine if there is a payload because
+        * operation.payloadRequired is not always correctly initialized (at least during the unit test)
+        */
       headers['content-type'] =
         typeof operation.payloadContentType !== 'undefined'
           ? operation.payloadContentType

Original file line number	Diff line number	Diff line change
`@@ -446,8 +446,12 @@ export function getResolver({`
`446`	`446`	`*`
`447`	`447`	`* NOTE: This may cause the user to encounter unexpected changes`
`448`	`448`	`*/`
`449`		`- if (operation.payloadRequired)`
	`449`	`+ if (operation.method !== 'get')`
`450`	`450`	`{`
	`451`	`+ /**`
	`452`	`+ * the check is done on the 'get' operation to determine if there is a payload because`
	`453`	`+ * operation.payloadRequired is not always correctly initialized (at least during the unit test)`
	`454`	`+ */`
`451`	`455`	`headers['content-type'] =`
`452`	`456`	`typeof operation.payloadContentType !== 'undefined'`
`453`	`457`	`? operation.payloadContentType`