Skip to content

Commit ae57222

Browse files
Caixinchen1gregkh
authored andcommittedJan 18, 2023
rapidio: devices: fix missing put_device in mport_cdev_open
[ Upstream commit d5b6e6eba3af11cb2a2791fa36a2524990fcde1a ] When kfifo_alloc fails, the refcount of chdev->dev is left incremental. We should use put_device(&chdev->dev) to decrease the ref count of chdev->dev to avoid refcount leak. Link: https://lkml.kernel.org/r/[email protected] Fixes: e8de370 ("rapidio: add mport char device driver") Signed-off-by: Cai Xinchen <[email protected]> Cc: Alexandre Bounine <[email protected]> Cc: Dan Carpenter <[email protected]> Cc: Jakob Koschel <[email protected]> Cc: John Hubbard <[email protected]> Cc: Matt Porter <[email protected]> Cc: Wang Weiyang <[email protected]> Cc: Yang Yingliang <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
1 parent 95040de commit ae57222

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed
 

‎drivers/rapidio/devices/rio_mport_cdev.c

+1
Original file line numberDiff line numberDiff line change
@@ -1971,6 +1971,7 @@ static int mport_cdev_open(struct inode *inode, struct file *filp)
19711971
sizeof(struct rio_event) * MPORT_EVENT_DEPTH,
19721972
GFP_KERNEL);
19731973
if (ret < 0) {
1974+
put_device(&chdev->dev);
19741975
dev_err(&chdev->dev, DRV_NAME ": kfifo_alloc failed\n");
19751976
ret = -ENOMEM;
19761977
goto err_fifo;

0 commit comments

Comments
 (0)
Please sign in to comment.