Skip to content

Commit 93dd36e

Browse files
committedNov 12, 2021
Merge branch 'master' of github.com:Hopding/pdf-lib
2 parents 4beebbe + 49b8e5e commit 93dd36e

File tree

2 files changed

+22
-24
lines changed

2 files changed

+22
-24
lines changed
 

‎.github/ISSUE_TEMPLATE/bug.yml

+18-23
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,14 @@ body:
55
- type: markdown
66
attributes:
77
value: |
8-
Thanks for taking the time to submit a bug report!
8+
Thanks for taking the time to submit a bug report! 😃
99
* Be sure to answer **all** of the questions below.
1010
* Provide lots of detail. Too much info is better than not enough.
1111
* If we can't reproduce the issue, we can't fix it.
1212
13-
Please help us help you by reading the following posts before submitting your report! 😃
14-
* [www.sscce.org](http://www.sscce.org/)
15-
* [Smart Questions](http://catb.org/~esr/faqs/smart-questions.html)
13+
If you've never created an issue on GitHub before, you might find these links helpful:
1614
* [45 GitHub Issues Dos and Don'ts](https://davidwalsh.name/45-github-issues-dos-donts)
15+
* [Smart Questions](http://catb.org/~esr/faqs/smart-questions.html)
1716
1817
You can read [MAINTAINERSHIP.md](https://github.com/Hopding/pdf-lib/blob/master/docs/MAINTAINERSHIP.md) to learn more about how this repo is maintained.
1918
- type: textarea
@@ -22,12 +21,6 @@ body:
2221
description: Clearly describe what you were trying to do when you found this bug.
2322
validations:
2423
required: true
25-
- type: textarea
26-
attributes:
27-
label: Why were you trying to do this?
28-
description: Explain why you were trying to do this.
29-
validations:
30-
required: true
3124
- type: textarea
3225
attributes:
3326
label: How did you attempt to do it?
@@ -50,17 +43,23 @@ body:
5043
attributes:
5144
label: How can we reproduce the issue?
5245
description: |
53-
Type out a list of specific steps we can take to reproduce the bug you've found. Your response must include both prose and code snippets. You must attach (or provides links to) any PDFs, images, or other files necessary to complete the steps.
54-
55-
> If you are unable to share certain files (e.g. confidential PDFs), then state this in your response. Be prepared to share the files privately (e.g. via email). If you are unable to do this then we probably can't fix the issue.
46+
📣 _This is a very important part of your report._
5647
57-
Your response should include **complete**, **executable** code, ideally in the form of a git repo. Read [www.sscce.org](http://www.sscce.org/) to learn how to create a Short, Self Contained, Correct (Compilable) Example.
48+
Provide **complete**, **executable** code that can be used to reproduce the bug (e.g. a git repo, ZIP file, or JSFiddle). You must attach (or provide links to) any PDFs, images, or other files necessary to run your code.
5849
59-
Please also read [Smart Questions](http://catb.org/~esr/faqs/smart-questions.html) and [45 GitHub Issues Dos and Don'ts](https://davidwalsh.name/45-github-issues-dos-donts).
50+
Your code example should be a [SSCCE](http://www.sscce.org/):
51+
- Short (Small) - Don't include code that is irrelevant or unnecessary.
52+
- Self Contained - Ensure everything is included, ready to go.
53+
- Correct - No additional code or changes are needed to copy, paste, and execute it.
54+
- Example - Demonstrates the problem you are reporting.
6055
61-
> We understand this is a nontrivial amount of reading. However, it's important that you create a well-defined report in order to reduce the demand placed on maintainers trying to help you. We want to make this a pleasant, efficient process for both you and us! 💖
56+
Please also type out a list of specific steps we can take to run your code and reproduce the issue. Depending on what you're reporting, this might be simple as running a JSFiddle or downloading a ZIP file and executing `node index.js`. Some issues will require more instructions.
6257
63-
If your response only includes incomplete code or doesn't clearly state how to execute the code you've provided, your report will be closed without comment.
58+
> If you are unable to share certain files (e.g. confidential PDFs), then state this in your response. Be prepared to share the files privately (e.g. via email). If you are unable to do this then we probably can't fix the issue.
59+
60+
⚠️ If your response includes incomplete code or doesn't clearly state how to execute the code you've provided, your report will be closed without comment.
61+
62+
💖 Thank you for taking the time to create a well-defined report! This helps reduce the demand placed on maintainers trying to help you. We want to make this a pleasant, efficient process for both you and us!
6463
validations:
6564
required: true
6665
- type: input
@@ -83,15 +82,11 @@ body:
8382
required: true
8483
- type: checkboxes
8584
attributes:
86-
label: Required Reading
85+
label: Checklist
8786
options:
88-
- label: I have read [www.sscce.org](http://www.sscce.org/).
89-
required: true
9087
- label: My report includes a Short, Self Contained, Correct (Compilable) Example.
9188
required: true
92-
- label: I have read [Smart Questions](http://catb.org/~esr/faqs/smart-questions.html).
93-
required: true
94-
- label: I have read [45 GitHub Issues Dos and Don'ts](https://davidwalsh.name/45-github-issues-dos-donts).
89+
- label: I have attached all PDFs, images, and other files needed to run my SSCCE.
9590
required: true
9691
- type: textarea
9792
attributes:

‎.github/PULL_REQUEST_TEMPLATE.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,11 @@
11
<!--
2+
👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇👇
3+
👉 🚨 Do not remove or skip any sections in this template ⛔️ 👈
4+
👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆👆
5+
26
Thank you for taking the time to make a PR! 💖
37
Please fill out this template completely to help us provide a prompt review. 😃
48
You can add more sections if you like. ✅
5-
Do not remove or skip any sections. ⛔️
69
-->
710

811
## What?

0 commit comments

Comments
 (0)
Please sign in to comment.