feat: allow font install on linux

Apply suggestions from code review

Co-authored-by: Douglas Eichelberger <[email protected]>

feat: add linux appdir

Apply suggestions from code review

Co-authored-by: Douglas Eichelberger <[email protected]>

Author: SMillerDev

Library/Homebrew/cask/artifact/moved.rb

@@ -180,7 +180,7 @@ def move_back(skip: false, force: false, adopt: false, command: nil, **options)
 
       def delete(target, force: false, successor: nil, command: nil, **_)
         ohai "Removing #{self.class.english_name} '#{target}'"
-        raise CaskError, "Cannot remove undeletable #{self.class.english_name}." if MacOS.undeletable?(target)
+        raise CaskError, "Cannot remove undeletable #{self.class.english_name}." if undeletable?(target)
 
         return unless Utils.path_occupied?(target)
 
@@ -196,6 +196,10 @@ def delete(target, force: false, successor: nil, command: nil, **_)
           Utils.gain_permissions_remove(target, command:)
         end
       end
+
+      def undeletable?(target); end
     end
   end
 end
+
+require "extend/os/cask/artifact/moved"

Library/Homebrew/cask/config.rb

@@ -33,10 +33,10 @@ class Config
       T::Hash[Symbol, String],
     )
 
-    sig { returns(T::Hash[Symbol, T.untyped]) }
+    sig { returns(T::Hash[Symbol, String]) }
     def self.defaults
       {
-        languages: LazyObject.new { MacOS.languages },
+        languages: LazyObject.new { ::OS::Mac.languages },
       }.merge(DEFAULT_DIRS).freeze
     end
 
@@ -221,5 +221,14 @@ def to_json(*options)
         explicit:,
       }.to_json(*options)
     end
+
+    private
+
+    sig { params(dir: Symbol).returns(T.any(String, Pathname)) }
+    def get_dir_path(dir)
+      T.cast(explicit.fetch(dir, env.fetch(dir, default.fetch(dir))), T.any(String, Pathname))
+    end
   end
 end
+
+require "extend/os/cask/config"

Library/Homebrew/cask/installer.rb

@@ -76,6 +76,7 @@ def fetch(quiet: nil, timeout: nil)
       satisfy_cask_and_formula_dependencies
     end
 
+    sig { void }
     def stage
       odebug "Cask::Installer#stage"
 
@@ -88,6 +89,7 @@ def stage
       raise e
     end
 
+    sig { void }
     def install
       start_time = Time.now
       odebug "Cask::Installer#install"
@@ -152,6 +154,7 @@ def check_deprecate_disable
       end
     end
 
+    sig { void }
     def check_conflicts
       return unless @cask.conflicts_with
 
@@ -168,6 +171,7 @@ def check_conflicts
       end
     end
 
+    sig { void }
     def uninstall_existing_cask
       return unless @cask.installed?
 
@@ -196,6 +200,7 @@ def download(quiet: nil, timeout: nil)
                                           timeout:)
     end
 
+    sig { void }
     def verify_has_sha
       odebug "Checking cask has checksum"
       return if @cask.sha256 != :no_check
@@ -213,6 +218,12 @@ def primary_container
       end
     end
 
+    sig { returns(ArtifactSet) }
+    def artifacts
+      @cask.artifacts
+    end
+
+    sig { params(to: Pathname).void }
     def extract_primary_container(to: @cask.staged_path)
       odebug "Extracting primary container"
 
@@ -242,7 +253,6 @@ def extract_primary_container(to: @cask.staged_path)
 
     sig { params(predecessor: T.nilable(Cask)).void }
     def install_artifacts(predecessor: nil)
-      artifacts = @cask.artifacts
       already_installed_artifacts = []
 
       odebug "Installing artifacts"
@@ -301,6 +311,7 @@ def check_macos_requirements
       raise CaskError, @cask.depends_on.macos.message(type: :cask)
     end
 
+    sig { void }
     def check_arch_requirements
       return if @cask.depends_on.arch.nil?
 
@@ -316,6 +327,7 @@ def check_arch_requirements
             "but you are running #{@current_arch}."
     end
 
+    sig { returns(T::Array[T.untyped]) }
     def cask_and_formula_dependencies
       return @cask_and_formula_dependencies if @cask_and_formula_dependencies
 
@@ -489,8 +501,6 @@ def finalize_upgrade
 
     sig { params(clear: T::Boolean, successor: T.nilable(Cask)).void }
     def uninstall_artifacts(clear: false, successor: nil)
-      artifacts = @cask.artifacts
-
       odebug "Uninstalling artifacts"
       odebug "#{::Utils.pluralize("artifact", artifacts.length, include_count: true)} defined", artifacts
 

Library/Homebrew/cask/quarantine.rb

@@ -266,3 +266,5 @@ def self.app_management_permissions_granted?(app:, command:)
     end
   end
 end
+
+require "extend/os/cask/quarantine"

Library/Homebrew/extend/os/cask/artifact/moved.rb

@@ -0,0 +1,5 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "extend/os/mac/cask/artifact/moved" if OS.mac?
+require "extend/os/linux/cask/artifact/moved" if OS.linux?

Library/Homebrew/extend/os/cask/config.rb

@@ -0,0 +1,4 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "extend/os/linux/cask/config" if OS.linux?

Library/Homebrew/extend/os/cask/quarantine.rb

@@ -0,0 +1,4 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "extend/os/linux/cask/quarantine" if OS.linux?

Library/Homebrew/extend/os/linux/cask/artifact/moved.rb

@@ -0,0 +1,23 @@
+# typed: strict
+# frozen_string_literal: true
+
+module OS
+  module Linux
+    module Cask
+      module Artifact
+        module Moved
+          extend T::Helpers
+
+          requires_ancestor { ::Cask::Artifact::Moved }
+
+          sig { params(target: Pathname).returns(T::Boolean) }
+          def undeletable?(target)
+            !target.parent.writable?
+          end
+        end
+      end
+    end
+  end
+end
+
+Cask::Artifact::Moved.prepend(OS::Linux::Cask::Config)

Library/Homebrew/extend/os/linux/cask/config.rb

@@ -0,0 +1,30 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "os/linux"
+
+module OS
+  module Linux
+    module Cask
+      module Config
+        module ClassMethods
+          DEFAULT_DIRS = T.let({
+            vst_plugindir:  "~/.vst",
+            vst3_plugindir: "~/.vst3",
+            fontdir:        "#{ENV.fetch("XDG_DATA_HOME", "~/.local/share")}/fonts",
+            appdir:         "~/.config/apps",
+          }.freeze, T::Hash[Symbol, String])
+
+          sig { returns(T::Hash[Symbol, String]) }
+          def defaults
+            {
+              languages: LazyObject.new { Linux.languages },
+            }.merge(DEFAULT_DIRS).freeze
+          end
+        end
+      end
+    end
+  end
+end
+
+Cask::Config.singleton_class.prepend(OS::Linux::Cask::Config::ClassMethods)

Library/Homebrew/extend/os/linux/cask/installer.rb

@@ -13,6 +13,8 @@ module Installer
 
         sig { void }
         def check_stanza_os_requirements
+          return if artifacts.all?(::Cask::Artifact::Font)
+
           raise ::Cask::CaskError, "macOS is required for this software."
         end
       end

Library/Homebrew/extend/os/linux/cask/quarantine.rb

@@ -0,0 +1,22 @@
+# typed: strict
+# frozen_string_literal: true
+
+module OS
+  module Linux
+    module Cask
+      module Quarantine
+        extend T::Helpers
+
+        requires_ancestor { ::Cask::Quarantine }
+
+        sig { returns(Symbol) }
+        def self.check_quarantine_support = :linux
+
+        sig { returns(T::Boolean) }
+        def self.available? = false
+      end
+    end
+  end
+end
+
+Cask::Quarantine.prepend(OS::Linux::Cask::Quarantine)

Library/Homebrew/extend/os/mac/cask/artifact/moved.rb

@@ -0,0 +1,25 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "cask/macos"
+
+module OS
+  module Mac
+    module Cask
+      module Artifact
+        module Moved
+          extend T::Helpers
+
+          requires_ancestor { ::Cask::Artifact::Moved }
+
+          sig { params(target: Pathname).returns(T::Boolean) }
+          def undeletable?(target)
+            MacOS.undeletable?(target)
+          end
+        end
+      end
+    end
+  end
+end
+
+Cask::Artifact::Moved.prepend(OS::Mac::Cask::Artifact::Moved)

Library/Homebrew/extend/os/mac/readall.rb

@@ -20,7 +20,7 @@ def valid_casks?(tap, os_name: nil, arch: ::Hardware::CPU.type)
 
         success = T.let(true, T::Boolean)
         tap.cask_files.each do |file|
-          cask = Cask::CaskLoader.load(file)
+          cask = ::Cask::CaskLoader.load(file)
 
           # Fine to have missing URLs for unsupported macOS
           macos_req = cask.depends_on.macos

Library/Homebrew/os/linux.rb

@@ -13,6 +13,8 @@ module Linux
     raise "Loaded OS::Linux on macOS!" if OS.mac?
     # rubocop:enable Homebrew/MoveToExtendOS
 
+    @languages = T.let([], T::Array[String])
+
     # Get the OS version.
     #
     # @api internal
@@ -56,5 +58,15 @@ def self.wsl_version
         Version::NULL
       end
     end
+
+    sig { returns(T::Array[String]) }
+    def self.languages
+      return @languages if @languages.present?
+
+      os_langs = Utils.popen_read("localectl", "list-locales")
+      os_langs = os_langs.scan(/[^ \n"(),]+/).map { |item| item.split(".").first.tr("_", "-") }
+
+      @languages = os_langs
+    end
   end
 end

Library/Homebrew/os/mac.rb

@@ -69,6 +69,7 @@ def self.preferred_perl_version
       end
     end
 
+    sig { returns(T::Array[String]) }
     def self.languages
       return @languages if @languages