Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extraneous clearFeedbackHandlers() in 02a #38

Open
rLinks234 opened this issue Nov 15, 2018 · 1 comment
Open

Extraneous clearFeedbackHandlers() in 02a #38

rLinks234 opened this issue Nov 15, 2018 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@rLinks234
Copy link
Contributor

group->clearFeedbackHandlers();

This is an example which erroneously infers to the user that they must clear feedback handlers, even when none were set.

Even further, feedback handlers are automatically destructed when the group is destructed, so we need to remove this extraneous call.

@rLinks234 rLinks234 added the bug Something isn't working label Nov 15, 2018
@iamtesch
Copy link
Contributor

This is extraneous, and we should remove, but it doesn't actually hurt anything to have the extra call. It just means a list is cleared. There is no double free or anything that occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants