Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshBatch causes exception in forward rendering #1165

Open
10c8 opened this issue Sep 25, 2023 · 2 comments
Open

MeshBatch causes exception in forward rendering #1165

10c8 opened this issue Sep 25, 2023 · 2 comments

Comments

@10c8
Copy link

10c8 commented Sep 25, 2023

Trying to use a MeshBatch to do GPU instancing in forward rendering leads to the following exception on line 276 of heaps/h3d/pass/ShaderManager.hx:

Missing param value h3d.shader.Shadow.Batch_Buffer2

Simply enabling the PBR pipeline like so seemingly fixes the issue:

h3d.mat.MaterialSetup.current = new h3d.mat.PbrMaterialSetup();

Is there a reason why PBR is necessary for instancing, or is that just a bug?

@10c8
Copy link
Author

10c8 commented Sep 26, 2023

Note: This is observed in the latest stable version (1.10.0).

@ncannasse
Copy link
Member

I think we fixed that on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants