New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lint and lgtm alerts #177

Open

9 tasks

tuliomir opened this issue Apr 8, 2022 · 0 comments

Labels

Contributor

tuliomir commented Apr 8, 2022

There are some linter and lgtm bot alerts that could be solved with pontual refactorings:

Use of externally-controlled format string issue raised by lgtm bot
no-unused-vars on
- src/logger.js
- __tests__/multisig.test.js
import/no-import-module-exports on
- src/helpers/constants.js
- src/helpers/validations.helper.js`
no-undef on
- setupTests-integration.js

Also study the possibility of solving:

import/no-extraneous-dependencies and global-require on
- setupTests.js
- setupTests-integration.js
- __tests__/test-utils.js
  This was discussed on another PR 174, but the solution may not be trivial and should be studied further.

The text was updated successfully, but these errors were encountered:

tuliomir added the refactor label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment