Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Pin version of Python used to a specific minor version #2035

Closed
2 tasks
acouch opened this issue Sep 17, 2024 · 0 comments
Closed
2 tasks

[Task]: Pin version of Python used to a specific minor version #2035

acouch opened this issue Sep 17, 2024 · 0 comments
Assignees
Labels

Comments

@acouch
Copy link
Collaborator

acouch commented Sep 17, 2024


Migrated from navapbc#184
Originally created by @chouinar on Wed, 28 Aug 2024 15:53:04 GMT


Summary

See: navapbc/template-application-flask#235 where details are described - this PR will just mirror these changes.

Acceptance criteria

  • Python pinned to 3.12
  • Details on how to upgrade Python to 3.13 (and beyond) documented
@acouch acouch closed this as completed Sep 17, 2024
acouch pushed a commit to navapbc/simpler-grants-gov that referenced this issue Sep 18, 2024
Fixes HHS#2035

Pin the Python version and document details on how to upgrade

Upgraded packages as well while I was tinkering with this

This is mirroring changes from the template repo:
navapbc/template-application-flask#235

Python releases new minor versions (3.12, 3.13, etc.) every year in
October. It usually takes a few weeks for all of our dependencies and
tooling to also be upgraded to the latest version, causing our builds to
break. There isn't much we can do except wait a few weeks and then do
the upgrade (assuming no breaking changes in features we use).

However, we had some of our dependencies pinned to the major version
(Python 3) so it has broken the past few years until it started working
again when the dependencies got fixed. This is just getting ahead of
that and making sure the upgrade to Python 3.13 doesn't cause any
problems.

This change is largely documentation as the Python version used in the
dockerfile + pyproject.toml already would have resolved to Python 3.12,
this just makes it so it won't auto-upgrade to 3.13 when that releases
in October.

The package updates are all very minor - we updated them not too long
ago, mostly just cleaning up a few things like the types-requests issue
that is no longer present.
acouch pushed a commit to navapbc/simpler-grants-gov that referenced this issue Sep 18, 2024
Fixes HHS#2035

Pin the Python version and document details on how to upgrade

Upgraded packages as well while I was tinkering with this

This is mirroring changes from the template repo:
navapbc/template-application-flask#235

Python releases new minor versions (3.12, 3.13, etc.) every year in
October. It usually takes a few weeks for all of our dependencies and
tooling to also be upgraded to the latest version, causing our builds to
break. There isn't much we can do except wait a few weeks and then do
the upgrade (assuming no breaking changes in features we use).

However, we had some of our dependencies pinned to the major version
(Python 3) so it has broken the past few years until it started working
again when the dependencies got fixed. This is just getting ahead of
that and making sure the upgrade to Python 3.13 doesn't cause any
problems.

This change is largely documentation as the Python version used in the
dockerfile + pyproject.toml already would have resolved to Python 3.12,
this just makes it so it won't auto-upgrade to 3.13 when that releases
in October.

The package updates are all very minor - we updated them not too long
ago, mostly just cleaning up a few things like the types-requests issue
that is no longer present.
acouch pushed a commit that referenced this issue Sep 18, 2024
…c#185)

Fixes #2035

Pin the Python version and document details on how to upgrade

Upgraded packages as well while I was tinkering with this

This is mirroring changes from the template repo:
navapbc/template-application-flask#235

Python releases new minor versions (3.12, 3.13, etc.) every year in
October. It usually takes a few weeks for all of our dependencies and
tooling to also be upgraded to the latest version, causing our builds to
break. There isn't much we can do except wait a few weeks and then do
the upgrade (assuming no breaking changes in features we use).

However, we had some of our dependencies pinned to the major version
(Python 3) so it has broken the past few years until it started working
again when the dependencies got fixed. This is just getting ahead of
that and making sure the upgrade to Python 3.13 doesn't cause any
problems.

This change is largely documentation as the Python version used in the
dockerfile + pyproject.toml already would have resolved to Python 3.12,
this just makes it so it won't auto-upgrade to 3.13 when that releases
in October.

The package updates are all very minor - we updated them not too long
ago, mostly just cleaning up a few things like the types-requests issue
that is no longer present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

2 participants