Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipfile: Python requirements are the wrong way around #2202

Open
Staudey opened this issue Sep 14, 2023 · 0 comments
Open

Pipfile: Python requirements are the wrong way around #2202

Staudey opened this issue Sep 14, 2023 · 0 comments

Comments

@Staudey
Copy link

Staudey commented Sep 14, 2023

Unless I'm completely mistaken the Python version requirements for scandir and typing are the wrong way around in the Pipfile. Both modules/functions are part of Python >= 3.5, but the Pipfile requires them for Python > 3.5 (i.e. all versions that already include that functionality, except 3.5 itself), instead of Python < 3.5 (i.e. all versions that need this functionality in form of an extra module)

guake/Pipfile

Line 30 in dcbf64c

scandir = {markers = "python_version > '3.5'"}

guake/Pipfile

Line 42 in dcbf64c

typing = {markers = "python_version > '3.5'"}

Both should be "python_version < '3.5'"

This even was the case before this commit: a38b47c#diff-230078d672f10d17463a8a6265cad825b790885898256a3365be90685caac58d

Davidy22 added a commit to Davidy22/guake that referenced this issue Oct 10, 2023
Davidy22 added a commit to Davidy22/guake that referenced this issue Oct 10, 2023
Davidy22 added a commit to Davidy22/guake that referenced this issue Oct 10, 2023
Davidy22 added a commit to Davidy22/guake that referenced this issue Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant