Skip to content

Commit a51c578

Browse files
committed
Issue #255: add handlers for exit status 1 and 2 (information and warning) for startnetldi, stopnetldi, and stopstone commands
1 parent 8557d97 commit a51c578

File tree

8 files changed

+16
-9
lines changed

8 files changed

+16
-9
lines changed

shared/repos/todeClient/GsDevKit-CommandLine.package/GsDevKitStartnetldiCommandLineHandler.class/instance/activate.st

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ activate
1414
show: (self runShellCommand: (self gemstoneBin / 'startnetldi') pathString args: argsArray exitStatus: [:proc |
1515
| es |
1616
es := (proc exitStatus bitAnd: 16rFF00) >> 8.
17-
proc isComplete and: [ es == 0 or: [ es == 2 ] ] ]);
17+
proc isComplete and: [ es == 0 or: [ es == 1 "information" or: [ es == 2 "warning"] ] ] ]);
1818
cr.
1919
self exitSuccess

shared/repos/todeClient/GsDevKit-CommandLine.package/GsDevKitStartnetldiCommandLineHandler.class/methodProperties.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"commandName" : "dkh 7/18/2014 14:09",
44
"description" : "dkh 7/18/2014 14:10" },
55
"instance" : {
6-
"activate" : "dkh 1/24/2019 18:37",
6+
"activate" : "dkh 9/19/2019 16:11",
77
"netldiArgsOn:" : "dkh 5/20/2016 11:57",
88
"produceNetldiArgs" : "dkh 11/6/2016 17:49",
99
"stoneName" : "dkh 7/18/2014 13:06" } }

shared/repos/todeClient/GsDevKit-CommandLine.package/GsDevKitStonesCommandLineHandler.class/methodProperties.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,4 +9,4 @@
99
"installedStones" : "dlh 10/3/2015 11:19",
1010
"produceStonesReport" : "dlh 10/2/2015 18:08",
1111
"runningNetldiReportOn:" : "dkh 1/25/2019 08:58",
12-
"runningStoneReportOn:" : "dkh 1/25/2019 08:57" } }
12+
"runningStoneReportOn:" : "dkh 1/25/2019 10:10" } }

shared/repos/todeClient/GsDevKit-CommandLine.package/GsDevKitStopnetldiCommandLineHandler.class/instance/activate.st

+4-1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ activate
2121
argsArray := sess ifNil: [ {(stoneInfo netLDI)} ] ifNotNil: [ {(sess netLDI)} ].
2222
Transcript
2323
cr;
24-
show: (self runShellCommand: (self gemstoneBin / 'stopnetldi') pathString args: argsArray);
24+
show: (self runShellCommand: (self gemstoneBin / 'stopnetldi') pathString args: argsArray exitStatus: [:proc |
25+
| es |
26+
es := (proc exitStatus bitAnd: 16rFF00) >> 8.
27+
proc isComplete and: [ es == 0 or: [ es == 1 "information" or: [ es == 2 "warning"] ] ] ]);
2528
cr.
2629
self exitSuccess

shared/repos/todeClient/GsDevKit-CommandLine.package/GsDevKitStopnetldiCommandLineHandler.class/methodProperties.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
"commandName" : "dkh 3/24/2015 07:29",
44
"description" : "dkh 3/24/2015 07:29" },
55
"instance" : {
6-
"activate" : "dkh 4/3/2016 15:01",
6+
"activate" : "dkh 9/23/2019 11:24",
77
"stoneName" : "dkh 3/24/2015 07:28" } }

shared/repos/todeClient/GsDevKit-CommandLine.package/GsDevKitStopstoneCommandLineHandler.class/instance/activate.st

+5-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,10 @@ activate
1515
argsArray := #().
1616
Transcript
1717
cr;
18-
show: (self runShellCommand: (self gs_serverBinGs / 'stopGemstone') pathString args: argsArray);
18+
show: (self runShellCommand: (self gs_serverBinGs / 'stopGemstone') pathString args: argsArray exitStatus: [:proc |
19+
| es ans |
20+
es := (proc exitStatus bitAnd: 16rFF00) >> 8.
21+
ans := proc isComplete and: [ es == 0 or: [ es == 1 "information" or: [ es == 2 "warning"] ] ].
22+
ans ]);
1923
cr.
2024
self exitSuccess

shared/repos/todeClient/GsDevKit-CommandLine.package/GsDevKitStopstoneCommandLineHandler.class/methodProperties.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,5 @@
33
"commandName" : "dkh 10/2/2015 14:42",
44
"description" : "dkh 10/2/2015 14:43" },
55
"instance" : {
6-
"activate" : "dkh 4/3/2016 15:01",
6+
"activate" : "dkh 9/19/2019 16:10",
77
"stoneName" : "dkh 10/2/2015 14:41" } }

shared/repos/todeClient/GsDevKit-CommandLine.package/monticello.meta/version

+2-2
Large diffs are not rendered by default.

0 commit comments

Comments
 (0)