Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check how your update not working #124

Open
atherdon opened this issue Apr 6, 2019 · 15 comments
Open

check how your update not working #124

atherdon opened this issue Apr 6, 2019 · 15 comments

Comments

@atherdon
Copy link
Member

atherdon commented Apr 6, 2019

@hirdbluebird

  1. install the project locally and start it locally
  2. find out an issue
  3. fix that issue at https://github.com/GroceriStar/pdf-export-component
@atherdon
Copy link
Member Author

atherdon commented Apr 6, 2019

this is an error that i get
image

@atherdon
Copy link
Member Author

atherdon commented Apr 9, 2019

please re-install pdf-export module - yesterday I published the newest version of it

@atherdon
Copy link
Member Author

atherdon commented Apr 9, 2019

I pushed a newest version of gs-fetch, but don't want to break your logic.
So, just to let you know - you can update fetch here later

@atherdon
Copy link
Member Author

atherdon commented Apr 9, 2019

diego drop a new version of pdf-renderer - i merge it to master, so please sync your fork and re-install packages

@hirdbluebird
Copy link
Member

The installation of dependencies is very long
image

@atherdon
Copy link
Member Author

try to run it again :)
the first time is always long, because yarn caching all stuff

@atherdon
Copy link
Member Author

image

@atherdon
Copy link
Member Author

image

@atherdon
Copy link
Member Author

i enabled menu(can be broken) & links, so it can be ok.
shall i add you to our npm org? or i'll publish it? i also want to implement a simple react component, using https://github.com/eunikitin/modern-package-boilerplate and see if rollup is working there...

@hirdbluebird
Copy link
Member

Add me

@atherdon
Copy link
Member Author

atherdon commented May 10, 2019 via email

@atherdon
Copy link
Member Author

question: maybe it will be better for you to move this code inside of pdf-xport, so you don't need to jump between repositories

@hirdbluebird
Copy link
Member

hirdbluebird commented May 10, 2019

npm username: hirdbluebird

Answer on question: yes, i can move this code to pdf-export repository

@atherdon
Copy link
Member Author

atherdon commented May 10, 2019 via email

@atherdon
Copy link
Member Author

atherdon commented May 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants