-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scenarios are not persisted correctly to/read from XLS template #104
Comments
@okworx I created a pre-release where I tried to solve this: https://github.com/GreenDelta/epd-editor/releases/tag/v6.0.3 |
Awesome, thanks! Will there be a macOS build too for testing? |
@francoislerall could you make a test build for macOS? |
Yes, today or tomorrow |
I have added a macOS build :) |
Thank you guys for the fix and the new build! While this works in principle, it will not work anymore when people use slashes for scenario names, which eventually someone will. Consider this case: Exporting and re-importing the XLSX template for this example will not work. Therefore, I suggest using something as a separator which is more unlikely to be used in names. How about three slashes, for example |
True, an alternative would be to only split the |
Test case:
create new EPD dataset
choose EF3.1 profile
create scenarios "100% incineration" and "100% recycling", leaving group empty, selecting the former as default
![CleanShot 2024-10-14 at 17 52 23@2x](https://private-user-images.githubusercontent.com/9449622/376312033-5e98349b-e02e-40a6-acd2-5d6c5f93d7dd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTU3MzksIm5iZiI6MTczOTU5NTQzOSwicGF0aCI6Ii85NDQ5NjIyLzM3NjMxMjAzMy01ZTk4MzQ5Yi1lMDJlLTQwYTYtYWNkMi01ZDZjNWY5M2Q3ZGQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDQ1NzE5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YjdhYmUxYWQ1Nzg2MDc0ZWY4ZDEwMGNmN2Y0MDRmZmI2MDM4MzM3YjNkYTFlNmJlZTYwZjc5MjJjMjdkZWIwMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.HdcXcXgn46bJktBGeLIQHEv7uUx81jZdDSxKVr9LhDQ)
add modules for both scenarios
![CleanShot 2024-10-14 at 17 53 19@2x](https://private-user-images.githubusercontent.com/9449622/376312340-fafe82e6-030f-46b5-9fb9-0c46e0a1ea43.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTU3MzksIm5iZiI6MTczOTU5NTQzOSwicGF0aCI6Ii85NDQ5NjIyLzM3NjMxMjM0MC1mYWZlODJlNi0wMzBmLTQ2YjUtOWZiOS0wYzQ2ZTBhMWVhNDMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMDQ1NzE5WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmVlYmUyMmY0MTg2MGY4ZTI0Mzk4ZTdhYTFjNDJkZWZlYTBiODVkN2UwNDA1MzBjNGQ0NzllN2Q0NjFjNGRhYyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.5Uoq2WxsKYK1YgINUYmfSDXN7V9nqPWTtXDGPxveSy0)
synchronize results table
export results table to XLS template
add some test numbers to XLS template:
results_EF3.1_dual_scenario.xlsx
create new EPD dataset
import XLS template
Observed behavior:
Expected behavior:
The same behavior can be observed when explicitly assigning a group ID. When adding another scenario group and using explicit group IDs, the group IDs and default status is lost as well (example XLS template: results_EF3.1_quad_scenario.xlsx)
In general, all declared scenarios without a group ID should be treated as belonging to the same group.
The text was updated successfully, but these errors were encountered: