Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A name colission with soymuchacho/libshared #69

Open
sskras opened this issue Mar 22, 2022 · 7 comments
Open

A name colission with soymuchacho/libshared #69

sskras opened this issue Mar 22, 2022 · 7 comments

Comments

@sskras
Copy link

sskras commented Mar 22, 2022

I thought about making this project a standalone lib.
This happened after I saw both Task Warrior and Timewarrior use the same library and that I am building it twice.

And googled this name and I found another project of the same name (born at the similar time, Jul 16, 2016):
https://github.com/soymuchacho/libshared

Would it be acceptable for this project to adjust the name? Just a thought.

@smemsh
Copy link
Contributor

smemsh commented Mar 22, 2022

Probably doesn't make sense to use a DSO that isn't linked statically. Taskwarrior/timewarrior have specific versions of libshared that they peg to (ie using git submodules) and the projects operate with different release schedules. In any case, libshared is probably only useful to the TW projects, and not a general purpose library, so a name collision isn't really problematic.

@sskras
Copy link
Author

sskras commented Mar 22, 2022

Fair enough.
I just don't get: why should I build libshared twice? Can't it be shared between these two projects in some other way?

@smemsh
Copy link
Contributor

smemsh commented Mar 30, 2022

You don't need to build libshared yourself, the build system does it, so it's not any more effort is it? Do you mean because you have to init the submodules?

@sskras
Copy link
Author

sskras commented Mar 31, 2022

Initting modules might be a reason too, although a weaker one.
My primary concern is compilation of slow machines, where the same compilation work has to be done twice.

@tbabej
Copy link
Member

tbabej commented Mar 31, 2022

I see where you're coming from, unfortunately, it's not exactly the same compilation work, because both timewarrior and taskwarrior often pin down different versions of libshared at any given point in time.

In case they are poining to the same commit in the submodule, you could circumvent the double build requirement by symlinking libshared from one repository into another 🤔

@sskras
Copy link
Author

sskras commented Mar 31, 2022

Ah, thanks for the tip! I guess I am fine with that then.

Still no plans to change the library name to something more specific?=)

@smemsh
Copy link
Contributor

smemsh commented Apr 2, 2022

Still no plans to change the library name to something more specific?=)

is it used somewhere outside the context of the GothenburgBitFactory programs' linktime namespaces, such that it's even possible to collide with anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants