Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update glob to v9.3.5 #3395

Draft
wants to merge 2 commits into
base: v7
Choose a base branch
from
Draft

Update glob to v9.3.5 #3395

wants to merge 2 commits into from

Conversation

westonruter
Copy link
Collaborator

@westonruter westonruter commented Feb 7, 2025 •
edited
Loading

Fixes #3379

Workbox is currently on glob v7 which is deprecated:

image

The earliest version being maintained is glob v9.

Important: This removes the globStrict option since this was removed in glob v9:

Removed silent and strict options. Any readdir errors are simply treated as "the directory could not be read", and it is treated as a normal file entry instead, like shells do.

@westonruter westonruter added the dependencies Pull requests that update a dependency file label Feb 7, 2025
This was referenced Feb 7, 2025
Open
Closed
@westonruter westonruter marked this pull request as draft February 7, 2025 17:51
@westonruter
Copy link
Collaborator Author

Alright, there is a back-compat breakage needs to be fixed. An error is currently happening:

Error: packages/workbox-build/src/lib/get-file-details.ts(46,7): error TS2769: No overload matches this call.
  The last overload gave the following error.
    Argument of type '{ cwd: string; follow: boolean | undefined; ignore: string[] | undefined; strict: boolean | undefined; }' is not assignable to parameter of type 'GlobOptions'.
      Object literal may only specify known properties, and 'strict' does not exist in type 'GlobOptions'.
    at makeError (/Users/runner/work/workbox/workbox/node_modules/execa/lib/error.js:59:11)
    at handlePromise (/Users/runner/work/workbox/workbox/node_modules/execa/index.js:114:26)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async transpile_typescript (/Users/runner/work/workbox/workbox/gulp-tasks/transpile-typescript.js:72:3)

@westonruter
Copy link
Collaborator Author

More errors now after addressing the removal of the strict option from glob:

/Users/runner/work/workbox/workbox/packages/workbox-build/node_modules/path-scurry/dist/commonjs/index.d.ts (5,30): Cannot find module 'node:path' or its corresponding type declarations.
/Users/runner/work/workbox/workbox/packages/workbox-build/node_modules/path-scurry/dist/commonjs/index.d.ts (7,36): Cannot find module 'node:fs' or its corresponding type declarations.
/Users/runner/work/workbox/workbox/packages/workbox-build/node_modules/path-scurry/node_modules/minipass/dist/commonjs/index.d.ts (5,30): Cannot find module 'node:events' or its corresponding type declarations.
/Users/runner/work/workbox/workbox/packages/workbox-build/node_modules/path-scurry/node_modules/minipass/dist/commonjs/index.d.ts (6,31): Cannot find module 'node:string_decoder' or its corresponding type declarations.
[18:02:20] 'build_node_ts_packages (workbox-build)' errored after 2.31 s
[18:02:20] TypeError: Cannot read properties of null (reading 'getSchemaForSymbol')
    at generateWorkboxBuildJSONSchema (/Users/runner/work/workbox/workbox/gulp-tasks/build-node-packages.js:66:30)
    at wrappedFunc (/Users/runner/work/workbox/workbox/gulp-tasks/utils/package-runner.js:131:31)
    at bound (node:domain:433:15)
    at runBound (node:domain:444:12)
    at asyncRunner (/Users/runner/work/workbox/workbox/node_modules/async-done/index.js:55:18)
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11)

@uibo-paybis
Copy link

Have you considered update to glob v11? v9 is quite old already

@westonruter
Copy link
Collaborator Author

@uibo-paybis yes, but it seemed like in theory it would be easier to update to v9 first rather than to jump two additional major versions and to deal with their back-compat breakages as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Glob Deprecated dependencies!!
2 participants
@westonruter @uibo-paybis