Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using finalDisplayedUrl instead of finalUrl when uploading reports ( for @lhci/[email protected]) #900

Closed
chaimabg opened this issue Apr 16, 2023 · 2 comments
Closed

Using finalDisplayedUrl instead of finalUrl when uploading reports ( for @lhci/[email protected]) #900

chaimabg opened this issue Apr 16, 2023 · 2 comments
Labels
P1

Comments

@chaimabg
Copy link

Is your feature request related to a problem? Please describe.
There is a problem with the displayed url (for # URLs) after creating the reports, encountered when running Lighthouse CI for # URLs (Issues related to the same problem : #896 and #887 )
The problem affects how reports are generated and displayed on lighthouse server.
We are expecting a separated report for each URL, generated regardless if they are full URLs or # URLs.

Describe the solution you'd like
The requested solution: using finalDisplayedUrl instead of finalUrl for Lighthouse CI version 0.12.0, when uploading reports (requested changes in upload.js)
@adamraine adamraine added the P1 label Apr 17, 2023
@adamraine
Copy link
Member

Yeah we should do this, finalUrl is deprecated.

@adamraine
Copy link
Member

Merging into #887

@adamraine adamraine mentioned this issue Apr 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamraine @chaimabg