Skip to content

Commit 92a3079

Browse files
committed
Changes in example ns according to issue bbatsov#64
According to conversation in issue bbatsov#64 there is better to use [] in ns declaration after special forms (:require, :use) since it's clearly describes data. I think same can be applied to :import and any other form in ns macro. I think both forms (short and long) are ok to use in real code. Short form: ```Clojure (:require [clojure [string :refer :all] [xml :refer :all]]) ``` Long form: ```Clojure (:require [clojure.string :refer :all]] [clojure.xml :refer :all]]) ```
1 parent d92904b commit 92a3079

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

Diff for: README.md

+9-6
Original file line numberDiff line numberDiff line change
@@ -253,14 +253,17 @@ pairwise constructs as found in e.g. `let` and `cond`.
253253
```Clojure
254254
(ns examples.ns
255255
(:refer-clojure :exclude [next replace remove])
256-
(:require (clojure [string :as string]
257-
[set :as set])
258-
[clojure.java.shell :as sh])
259-
(:use (clojure zip xml))
256+
(:require [clojure [string :as string
257+
:refer [blank?]]
258+
[set :as set]]
259+
[clojure.java.shell :as sh]
260+
[cascalog.api :refer :all]
261+
[cascalog.ops :as c])
262+
(:use [clojure xml zip])
260263
(:import java.util.Date
261264
java.text.SimpleDateFormat
262-
(java.util.concurrent Executors
263-
LinkedBlockingQueue)))
265+
[java.util.concurrent Executors
266+
LinkedBlockingQueue]))
264267
```
265268

266269
* Avoid single-segment namespaces.

0 commit comments

Comments
 (0)