Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve game_state matching for phase trigger #74

Open
jimmydorry opened this issue Mar 4, 2016 · 3 comments
Open

Improve game_state matching for phase trigger #74

jimmydorry opened this issue Mar 4, 2016 · 3 comments
Assignees
@jimmydorry
Labels
bug
Milestone
V5

Comments

@jimmydorry
Copy link
Member

#73 (comment)

I guess there is a new game_state that breaks things. @MNoya has this been happening in eletd or PMP?
@jimmydorry jimmydorry added the bug label Mar 4, 2016
@jimmydorry jimmydorry self-assigned this Mar 4, 2016
@SinZ163
Copy link
Member

SinZ163 commented Mar 4, 2016

It's not new https://github.com/SteamRE/SteamKit/blob/f6c0578506690d63a2b159340fe19835fe33564c/Resources/Protobufs/dota/dota_gcmessages_common.proto#L544

@jimmydorry
Copy link
Member Author

Why haven't we seen this as far larger problem then? Does it kick the game into that state faster than it used to? I can probably answer my own question tomorrow by looking in the dataset.

@SinZ163 SinZ163 added this to the V5 milestone Mar 5, 2016
@jimmydorry
Copy link
Member Author

Recent related changes here:

9c3c5e2

0e4222d

025bfd0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimmydorry jimmydorry

Labels
bug
Projects
None yet
Milestone
V5
Development

No branches or pull requests
2 participants
@SinZ163 @jimmydorry