Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvest source user experience and workflows #59

Open
3 of 4 tasks
johnmartin opened this issue Apr 18, 2013 · 5 comments
Open
3 of 4 tasks

Harvest source user experience and workflows #59

johnmartin opened this issue Apr 18, 2013 · 5 comments

Comments

@johnmartin
Copy link
Contributor

OK, so in order to improve the workflow of the harvest source forms and org admin stuff there needs to be:

  • A public listing for harvest sources within an organization so that the breadcrumbs link to a public page
  • Within the harvest source admin area of a org, there should be an error count/link to last job (if a job exists)
  • When in admin mode for a harvest source and said harvest source is owned by an org there needs to be a way to get back to the "org/admin/harvest source" page
  • When a harvest source get's created and it is linked to an organization, the redirect should go to the "org/admin/harvest source" page
@ghost ghost assigned johnmartin Apr 18, 2013
@johnmartin
Copy link
Contributor Author

@kindly @amercader @shevski

OK, I've completed three of these... however I cannot figure out how to do the last one (as it appears to be in the package controller on CKAN core).

Anyways to test with the first three enabled, you'll need:

@amercader
Copy link
Contributor

Nice work @johnmartin

Some comments:

  • The breadcrumbs on the public listing for harvest sources within an organization only shows

Home / Organizations / {name}

Should be

Home / Organizations / {name} / Harvest Sources

  • When I'm on the org's harvest source page (eg http://localhost:5000/organization/harvest/alaska-gov) how do I get to the admin page (eg http://localhost:5000/organization/harvest/edit/alaska-gov)? I would expect clicking on the Admin button, but this links to the org edit page.
  • The last one will be tricky. The package controller has a _form_save_redirect method that controls where to redirect after an edit. There are ways from ancient times for defining an alternative url (the package_new_return_url config option, but this will not take into account the organization name. We may need a new extension point on IDatasetForm for this where we can define all the necessary logic.

@johnmartin
Copy link
Contributor Author

  • Breadcrumbs: it is deliberate that it doesn't have 'Harvest Sources' on the end of the breadcrumbs. As the page header tabs act as the sub-breadcrumb (see other tabs in org pages)
  • Org's harvest source page: it's the public page so therefore the link goes to the public listing of that harvest source, however when on the admin harvest source listing links goto the admin page for that harvest source. We possibly need something that means when you see a listing of items and you can 'admin' said items (datasets, groups, sources, etc). But this is something that we should think about for 2.1
  • OK

@johnmartin
Copy link
Contributor Author

FYI: I've now created a core 2.1 issue for the edit listing thing ckan/ckan#863

Also: we can merge this without the 4th item support. Perhaps we make a new issue for the last item so we can get this into the next package?

@shevski
Copy link

shevski commented May 1, 2013

Agree with getting the first three merged first. Would be good to test this.
Any update on how long item 4 may take?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants