cmd/web: fix wrong ExternalURL when specify port via CLI flag

unknwon · achilleas-k · commit 41b9e255cd56 · 2020-07-29T15:48:50.000+02:00
Fixes #5936.
diff --git a/internal/cmd/web.go b/internal/cmd/web.go
@@ -706,7 +706,7 @@ func runWeb(c *cli.Context) error {
 
 	// Flag for port number in case first time run conflict.
 	if c.IsSet("port") {
-		conf.Server.URL.Host = strings.Replace(conf.Server.URL.Host, conf.Server.URL.Port(), c.String("port"), 1)
+		conf.Server.URL.Host = strings.Replace(conf.Server.URL.Host, ":"+conf.Server.URL.Port(), ":"+c.String("port"), 1)
 		conf.Server.ExternalURL = conf.Server.URL.String()
 		conf.Server.HTTPPort = c.String("port")
 	}

Original file line number	Diff line number	Diff line change
`@@ -706,7 +706,7 @@ func runWeb(c *cli.Context) error {`
`706`	`706`
`707`	`707`	`// Flag for port number in case first time run conflict.`
`708`	`708`	`if c.IsSet("port") {`
`709`		`- conf.Server.URL.Host = strings.Replace(conf.Server.URL.Host, conf.Server.URL.Port(), c.String("port"), 1)`
	`709`	`+ conf.Server.URL.Host = strings.Replace(conf.Server.URL.Host, ":"+conf.Server.URL.Port(), ":"+c.String("port"), 1)`
`710`	`710`	`conf.Server.ExternalURL = conf.Server.URL.String()`
`711`	`711`	`conf.Server.HTTPPort = c.String("port")`
`712`	`712`	`}`