Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PATCH vs PUT for update calls #113

Open
sjauld opened this issue Jan 24, 2022 · 1 comment
Open

PATCH vs PUT for update calls #113

sjauld opened this issue Jan 24, 2022 · 1 comment

Comments

@sjauld
Copy link
Contributor

sjauld commented Jan 24, 2022

Is there any reason that we use http.MethodPut instead of http.MethodPatch for updating? In a recent update, this caused the provider to change the settings of a fusionauth_idp_saml_v2 resource, since there was a new field the provider didn't know about and hence it didn't see the diff it was applying. Using http.MethodPatch would prevent this happening.

@MCBrandenburg
Copy link
Contributor

No particular reason, I went with PUT since I was using the updates for most the resources. I wouldn't be opposed to changing it in idphelpers.go once I get caught up with the changes in the last few versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants