fix cs, phpstan and spellcheck

Author: dbu

.github/workflows/spellcheck.yml

@@ -15,17 +15,15 @@ jobs:
       - uses: actions/checkout@v4
       - name: Set up Python
         uses: actions/setup-python@v5
-        with:
-          python-version: 3.7
       - name: Install dependencies
         run: |
           python -m pip install --upgrade setuptools
           python -m pip install -r doc/requirements.txt
       - name: Run spell check
         run: |
           make -C doc/ spelling
-          if [[ -s "doc/_build/spelling/output.txt" ]]; then echo "\nSpelling errors found\n" && cat "doc/_build/spelling/output.txt"; fi
+          if [[ -s "_build/spelling/output.txt" ]]; then echo "\nSpelling errors found\n" && cat "_build/spelling/output.txt"; fi
       - name: Spellcheck
         run: |
-          if [[ -s "doc/_build/spelling/output.txt" ]]; then cat "doc/_build/spelling/output.txt"; fi
-          if [[ -s "doc/_build/spelling/output.txt" ]]; then false; fi
+          if [[ -s "_build/spelling/output.txt" ]]; then cat "_build/spelling/output.txt"; fi
+          if [[ -s "_build/spelling/output.txt" ]]; then false; fi

.github/workflows/static.yml

@@ -16,7 +16,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Pull in optional dependencies
-        run: composer require --no-update phpunit/phpunit toflar/psr6-symfony-http-cache-store:^4.2
+        run: composer require --no-update phpunit/phpunit toflar/psr6-symfony-http-cache-store:^4.2 symfony/process
 
       - name: Cache Vendor
         id: cache-vendor

doc/requirements.txt

@@ -4,3 +4,4 @@ sphinx-tabs
 sphinxcontrib-phpdomain
 sphinxcontrib-spelling
 pyenchant
+

phpstan.neon.dist

@@ -2,10 +2,3 @@ parameters:
     level: 1
     paths:
         - src
-    excludePaths:
-        analyseAndScan:
-            # contains code to support legacy phpunit versions
-            # TODO: clean up the code in this namespace and support fewer phpunit versions
-            - src/Test/*
-            # contains BC code to support Symfony 3.4 that would not work with never versions
-            - src/BaseEvent.php

src/ProxyClient/Cloudflare.php

@@ -54,7 +54,7 @@ class Cloudflare extends HttpProxyClient implements ClearCapable, PurgeCapable,
     public function __construct(
         Dispatcher $dispatcher,
         array $options = [],
-        ?RequestFactoryInterface $requestFactory = null
+        ?RequestFactoryInterface $requestFactory = null,
     ) {
         if (!function_exists('json_encode')) {
             throw new \Exception('ext-json is required for cloudflare invalidation');

src/ProxyClient/Fastly.php

@@ -50,7 +50,7 @@ class Fastly extends HttpProxyClient implements ClearCapable, PurgeCapable, Refr
     public function __construct(
         Dispatcher $dispatcher,
         array $options = [],
-        ?RequestFactoryInterface $requestFactory = null
+        ?RequestFactoryInterface $requestFactory = null,
     ) {
         if (!function_exists('json_encode')) {
             throw new \Exception('ext-json is required for fastly invalidation');

src/Test/EventDispatchingHttpCacheTestCase.php

@@ -400,7 +400,7 @@ class TestListener implements EventSubscriberInterface
     public function __construct(
         EventDispatchingHttpCacheTestCase $test,
         CacheInvalidation $kernel,
-        Request $request
+        Request $request,
     ) {
         $this->test = $test;
         $this->kernel = $kernel;
@@ -480,7 +480,7 @@ class SimpleListener
     public function __construct(
         EventDispatchingHttpCacheTestCase $test,
         CacheInvalidation $kernel,
-        Request $request
+        Request $request,
     ) {
         $this->test = $test;
         $this->kernel = $kernel;

src/Test/PHPUnit/AbstractCacheConstraint.php

@@ -21,6 +21,8 @@ public function __construct(
     ) {
     }
 
+    abstract public function getValue(): string;
+
     public function matches($other): bool
     {
         if (!$other instanceof ResponseInterface) {

src/Test/Proxy/AbstractProxy.php

@@ -93,6 +93,9 @@ protected function wait(int $timeout, callable $callback): bool
      */
     protected function runCommand(string $command, array $arguments): void
     {
+        if (!class_exists(Process::class)) {
+            throw new \RuntimeException('Running commands requires the symfony/process component');
+        }
         $process = new Process(array_merge([$command], $arguments));
         $process->run();