Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags #26

Open
5 tasks done
nvllz opened this issue Dec 25, 2023 · 11 comments
Open
5 tasks done

Tags #26

nvllz opened this issue Dec 25, 2023 · 11 comments
Labels
feature request Issue is about a new feature in the app

Comments

@nvllz
Copy link

nvllz commented Dec 25, 2023

Checklist

  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Describe the solution you'd like
I'd like the application to support tagging of media files, allowing users to tag any number of files with a short phrase that would return related items when searched. A single media item could be tagged with multiple tag phrases, and these should only appear within the application, without changing the EXIF data of the file.

Describe alternatives you've considered
Users may consider grouping their media into albums (folders), but this somehow blocks the ability to discover different images based on numerous details. This feature would open up a great way to manage collections.

Additional context
There are many ways to use this kind of feature, but trying to understand it can change the way you work with larger collections of images and videos. Separating vacation pictures tagged with "summer-2023" and "summer-2022", but still having some of the common pictures tagged with "beach", makes the whole collection more accessible and simply more user-friendly, if used properly.

It was reported several times in the original repo (issue 373), but unfortunately never made it into the application. I hope you will consider this idea.

@nvllz nvllz added feature request Issue is about a new feature in the app needs triage Issue is not yet ready for PR authors to take up labels Dec 25, 2023
@Aga-C Aga-C removed the needs triage Issue is not yet ready for PR authors to take up label Dec 25, 2023
@ghost
Copy link

ghost commented Dec 26, 2023

This would simply be amazing for all users who manage their media files locally.
There is another FOSS gallery app that already implemented this, Aves, but sadly the UI is outdated and this gallery app is simply better.

You could also add the ability to search for xmp/iptc metadata tags. In alot of professional photo editing programs you can automatically add tags to images - for example 'Mountains' or 'Cats'. Being able to search for these tags in the app would be amazing, since you can add the tags in one place and read them in another. This means that it doesn't matter what file/media viewer you use, the tags are visible everywhere. The same also applies to favorites.

Hope you are interested in implementing this!

@test2a
Copy link

test2a commented Dec 28, 2023

@BabyBenefactor maybe #19 can help to automate this?

@ghost
Copy link

ghost commented Dec 28, 2023

@BabyBenefactor maybe #19 can help to automate this?

Thanks, didn't know about this.

Still, it would be great to be able to search through the metadata with this gallery app. And maybe mark the files in metadata aswell when pressing the favorite button to improve cross-platform compatibility.

@jan-leila
Copy link

this seams like it could be broken down into 2-4 smaller feature requests such as:

  • ability to view tag information on individual images
  • ability to edit tag information on multiple images
  • ability to filter image views based on a search query of tags
  • ability to switch folder view to tag view

we should also consider the UI implementations of all of these

individual image things would prob just go in the hamburger menu on an image

but for the other two where should those go, should we add a new filter icon that opens a model to be able in the future for example be able to filter by other data such as image creation time, image location etc

and for the tag view option I would imagine that would go under the "Change view type" button

if we do go with adding the LLM tagging in the future we should also have an option to disable using the tags that it generates on both group and filter views as well as having a way to distinguish them and audit them on individual images

@test2a
Copy link

test2a commented Jan 3, 2024

my personal desire is to identify faces. Not sure how that can be done on android locally but softwares have been doing that on desktop for a decade and phones are now just as powerful, maybe more but yeah. we should not have to reinvent the wheel.

@naveensingh
Copy link
Member

@test2a grouping together similar faces is not that hard, the issue is the increase in app size depending on the implementation.

@nvllz
Copy link
Author

nvllz commented Jan 3, 2024

I don't think you understand what I mean. It's mainly about manual tagging, not some AI thing grouping images for you, nor modifying file EXIF data.

The user tags a group of images (img1, img2, img3, img4) with the phrase "landscape". In addition, the user wants to tag two of the first landscape images with "river". This way, when searching for river images, the user will only get img1 and img2 from this group, but all 4 files when searching for landscape. This is simple, but very useful.

Once the application has this simple tagging feature, we can discuss language models and other more advanced things. It's been requested for years, and if we have to wait a few more years because the approach is too complex, let's get it done in the simplest way first, please.

@jan-leila
Copy link

ya things should be 1 step at a time here:

  • ability to even see tags on individual media
  • ability to edit tags on individual media
  • ability to filter view on tags for all media
  • ability to groups view by tags
  • auto person tagging
  • auto image description tagging

we shouldnt be thinking about those last 2 until the first 4 are in because they mean nothing without the first 4, if you want those last two before the first 4 then just use another tool for it because it doesnt interact with the current tool as stands

@tobiasBora
Copy link

Would love this as well, together to add comments to pictures. But I'd like this to be written in the exif data as well so that this is mot lost when importing images from a laptop (with digikam for me).

@naveensingh naveensingh pinned this issue Jul 26, 2024
@OkyDooky
Copy link

OkyDooky commented Aug 7, 2024

I'd also recommend targeting whatever metadata category/type is most common for desktop gallery apps, since images tagged in Aves show them as like comments or something in Gwenview. It was quite the buzzkill. I think it's XMP that Aves targets?

@Saarsk
Copy link

Saarsk commented Sep 28, 2024

Tags seem interesting.

Though, I'm not sure it seem worth the hassle to tag photos unless the tags actually follows the file. So that they still appear when I either upload it to Nextcloud or to my computer and open it in Dolphin/Gwenview.

Then again, I can understand how someone wouldn't want the tags to follow the file.

I think it ideally should be possible to do both, optionally, although I'm not sure whether there are metadata standards for this or whether it needs to be hacked into the metadata where it "kinda sorta fits". For all I know, Nextcloud, Paperless, Dolphin and others might as well just have a db file for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is about a new feature in the app
Projects
None yet
Development

No branches or pull requests

8 participants